Bug#833609: ring: Crashes on startup after showing popup - triggered by missing dring?

[Petter Reinholdtsen]

Package: ring
Version: 20160729.2.7a7dbd6~dfsg1-1

When running gnome-ring in testing right now, the client pop up a error
message with strange content and crashes (sorry for the norwegian error
message):

  % LANGUAGE= LC_ALL=C DISPLAY=:0 gnome-ring
  ** Message: Ring GNOME client version: 1.0.0
  ** Message: git ref: unknown
  "Error : dring is not available, make sure it is running"

  ** (gnome-ring:3414): WARNING **: Error : dring is not available, make sure it is running
  Gtk-Message: GtkDialog mapped without a transient parent. This is discouraged.

  ** (gnome-ring:3414): ERROR **: 
  Sporings-/stoppunkts-felle
  %

Valgrind report several issues:

==3636== Memcheck, a memory error detector
==3636== Copyright (C) 2002-2015, and GNU GPL'd, by Julian Seward et al.
==3636== Using Valgrind-3.12.0.SVN and LibVEX; rerun with -h for copyright info
==3636== Command: gnome-ring
==3636== 
** Message: Ring GNOME client version: 1.0.0
** Message: git ref: unknown
==3642== Warning: invalid file descriptor 1024 in syscall close()
==3642== Warning: invalid file descriptor 1025 in syscall close()
==3642== Warning: invalid file descriptor 1026 in syscall close()
==3642== Warning: invalid file descriptor 1027 in syscall close()
==3642==    Use --log-fd=<number> to select an alternative log fd.
==3642== Warning: invalid file descriptor 1028 in syscall close()
==3642== Warning: invalid file descriptor 1029 in syscall close()
==3642== Warning: invalid file descriptor 1030 in syscall close()
"Error : dring is not available, make sure it is running"
==3636== Invalid read of size 1
==3636==    at 0xF171410: vfprintf (vfprintf.c:1632)
==3636==    by 0xF220044: __vasprintf_chk (vasprintf_chk.c:66)
==3636==    by 0x7326CE8: vasprintf (stdio2.h:210)
==3636==    by 0x7326CE8: g_vasprintf (gprintf.c:316)
==3636==    by 0x730167C: g_strdup_vprintf (gstrfuncs.c:514)
==3636==    by 0x72E9821: g_logv (gmessages.c:987)
==3636==    by 0x72E9BDE: g_log (gmessages.c:1119)
==3636==    by 0x12D97D: init_exception_dialog(char const*) (ring_client.cpp:131)
==3636==    by 0x12F78A: ring_client_startup(_GApplication*) (ring_client.cpp:443)
==3636==    by 0x70561D3: _g_closure_invoke_va (gclosure.c:867)
==3636==    by 0x70709A5: g_signal_emit_valist (gsignal.c:3294)
==3636==    by 0x707108E: g_signal_emit (gsignal.c:3441)
==3636==    by 0x6D6B0B1: g_application_register (gapplication.c:2049)
==3636==  Address 0x205e8d68 is 24 bytes inside a block of size 80 free'd
==3636==    at 0x4C2CDFB: free (vg_replace_malloc.c:530)
==3636==    by 0x505EED1: Interfaces::DBusErrorHandlerDefault::invalidInterfaceError(QString const&) (dbuserrorhandlerdefault.cpp:33)
==3636==    by 0x505C605: VideoManager::instance() (videomanager.cpp:42)
==3636==    by 0x506A1BE: VideoRendererManager::VideoRendererManager() (videorenderermanager.cpp:84)
==3636==    by 0x506A394: VideoRendererManager::instance() (videorenderermanager.cpp:98)
==3636==    by 0x4F8AF02: CallModel::CallModel() (callmodel.cpp:155)
==3636==    by 0x4F9204C: CallModel::instance() (callmodel.cpp:132)
==3636==    by 0x12ED18: ring_client_startup(_GApplication*) (ring_client.cpp:441)
==3636==    by 0x70561D3: _g_closure_invoke_va (gclosure.c:867)
==3636==    by 0x70709A5: g_signal_emit_valist (gsignal.c:3294)
==3636==    by 0x707108E: g_signal_emit (gsignal.c:3441)
==3636==    by 0x6D6B0B1: g_application_register (gapplication.c:2049)
==3636==  Block was alloc'd at
==3636==    at 0x4C2BBCF: malloc (vg_replace_malloc.c:299)
==3636==    by 0x7658AA1: QArrayData::allocate(unsigned long, unsigned long, unsigned long, QFlags<QArrayData::AllocationOption>) (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.6.1)
==3636==    by 0x765B2AF: QByteArray::QByteArray(int, Qt::Initialization) (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.6.1)
==3636==    by 0x76E8744: QString::toLatin1_helper(QChar const*, int) (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.6.1)
==3636==    by 0x76E878F: QString::toLatin1_helper(QString const&) (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.6.1)
==3636==    by 0x505EEBC: toLatin1 (qstring.h:509)
==3636==    by 0x505EEBC: Interfaces::DBusErrorHandlerDefault::invalidInterfaceError(QString const&) (dbuserrorhandlerdefault.cpp:33)
==3636==    by 0x505C605: VideoManager::instance() (videomanager.cpp:42)
==3636==    by 0x506A1BE: VideoRendererManager::VideoRendererManager() (videorenderermanager.cpp:84)
==3636==    by 0x506A394: VideoRendererManager::instance() (videorenderermanager.cpp:98)
==3636==    by 0x4F8AF02: CallModel::CallModel() (callmodel.cpp:155)
==3636==    by 0x4F9204C: CallModel::instance() (callmodel.cpp:132)
==3636==    by 0x12ED18: ring_client_startup(_GApplication*) (ring_client.cpp:441)
==3636== 
==3636== Invalid read of size 1
==3636==    at 0x4C32EE0: __GI_mempcpy (vg_replace_strmem.c:1518)
==3636==    by 0xF19B66D: _IO_default_xsputn (genops.c:438)
==3636==    by 0xF170C5A: vfprintf (vfprintf.c:1632)
==3636==    by 0xF220044: __vasprintf_chk (vasprintf_chk.c:66)
==3636==    by 0x7326CE8: vasprintf (stdio2.h:210)
==3636==    by 0x7326CE8: g_vasprintf (gprintf.c:316)
==3636==    by 0x730167C: g_strdup_vprintf (gstrfuncs.c:514)
==3636==    by 0x72E9821: g_logv (gmessages.c:987)
==3636==    by 0x72E9BDE: g_log (gmessages.c:1119)
==3636==    by 0x12D97D: init_exception_dialog(char const*) (ring_client.cpp:131)
==3636==    by 0x12F78A: ring_client_startup(_GApplication*) (ring_client.cpp:443)
==3636==    by 0x70561D3: _g_closure_invoke_va (gclosure.c:867)
==3636==    by 0x70709A5: g_signal_emit_valist (gsignal.c:3294)
==3636==  Address 0x205e8d9e is 78 bytes inside a block of size 80 free'd
==3636==    at 0x4C2CDFB: free (vg_replace_malloc.c:530)
==3636==    by 0x505EED1: Interfaces::DBusErrorHandlerDefault::invalidInterfaceError(QString const&) (dbuserrorhandlerdefault.cpp:33)
==3636==    by 0x505C605: VideoManager::instance() (videomanager.cpp:42)
==3636==    by 0x506A1BE: VideoRendererManager::VideoRendererManager() (videorenderermanager.cpp:84)
==3636==    by 0x506A394: VideoRendererManager::instance() (videorenderermanager.cpp:98)
==3636==    by 0x4F8AF02: CallModel::CallModel() (callmodel.cpp:155)
==3636==    by 0x4F9204C: CallModel::instance() (callmodel.cpp:132)
==3636==    by 0x12ED18: ring_client_startup(_GApplication*) (ring_client.cpp:441)
==3636==    by 0x70561D3: _g_closure_invoke_va (gclosure.c:867)
==3636==    by 0x70709A5: g_signal_emit_valist (gsignal.c:3294)
==3636==    by 0x707108E: g_signal_emit (gsignal.c:3441)
==3636==    by 0x6D6B0B1: g_application_register (gapplication.c:2049)
==3636==  Block was alloc'd at
==3636==    at 0x4C2BBCF: malloc (vg_replace_malloc.c:299)
==3636==    by 0x7658AA1: QArrayData::allocate(unsigned long, unsigned long, unsigned long, QFlags<QArrayData::AllocationOption>) (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.6.1)
==3636==    by 0x765B2AF: QByteArray::QByteArray(int, Qt::Initialization) (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.6.1)
==3636==    by 0x76E8744: QString::toLatin1_helper(QChar const*, int) (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.6.1)
==3636==    by 0x76E878F: QString::toLatin1_helper(QString const&) (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.6.1)
==3636==    by 0x505EEBC: toLatin1 (qstring.h:509)
==3636==    by 0x505EEBC: Interfaces::DBusErrorHandlerDefault::invalidInterfaceError(QString const&) (dbuserrorhandlerdefault.cpp:33)
==3636==    by 0x505C605: VideoManager::instance() (videomanager.cpp:42)
==3636==    by 0x506A1BE: VideoRendererManager::VideoRendererManager() (videorenderermanager.cpp:84)
==3636==    by 0x506A394: VideoRendererManager::instance() (videorenderermanager.cpp:98)
==3636==    by 0x4F8AF02: CallModel::CallModel() (callmodel.cpp:155)
==3636==    by 0x4F9204C: CallModel::instance() (callmodel.cpp:132)
==3636==    by 0x12ED18: ring_client_startup(_GApplication*) (ring_client.cpp:441)
==3636== 
==3636== Invalid read of size 1
==3636==    at 0x4C32EF0: __GI_mempcpy (vg_replace_strmem.c:1518)
==3636==    by 0xF19B66D: _IO_default_xsputn (genops.c:438)
==3636==    by 0xF170C5A: vfprintf (vfprintf.c:1632)
==3636==    by 0xF220044: __vasprintf_chk (vasprintf_chk.c:66)
==3636==    by 0x7326CE8: vasprintf (stdio2.h:210)
==3636==    by 0x7326CE8: g_vasprintf (gprintf.c:316)
==3636==    by 0x730167C: g_strdup_vprintf (gstrfuncs.c:514)
==3636==    by 0x72E9821: g_logv (gmessages.c:987)
==3636==    by 0x72E9BDE: g_log (gmessages.c:1119)
==3636==    by 0x12D97D: init_exception_dialog(char const*) (ring_client.cpp:131)
==3636==    by 0x12F78A: ring_client_startup(_GApplication*) (ring_client.cpp:443)
==3636==    by 0x70561D3: _g_closure_invoke_va (gclosure.c:867)
==3636==    by 0x70709A5: g_signal_emit_valist (gsignal.c:3294)
==3636==  Address 0x205e8d9c is 76 bytes inside a block of size 80 free'd
==3636==    at 0x4C2CDFB: free (vg_replace_malloc.c:530)
==3636==    by 0x505EED1: Interfaces::DBusErrorHandlerDefault::invalidInterfaceError(QString const&) (dbuserrorhandlerdefault.cpp:33)
==3636==    by 0x505C605: VideoManager::instance() (videomanager.cpp:42)
==3636==    by 0x506A1BE: VideoRendererManager::VideoRendererManager() (videorenderermanager.cpp:84)
==3636==    by 0x506A394: VideoRendererManager::instance() (videorenderermanager.cpp:98)
==3636==    by 0x4F8AF02: CallModel::CallModel() (callmodel.cpp:155)
==3636==    by 0x4F9204C: CallModel::instance() (callmodel.cpp:132)
==3636==    by 0x12ED18: ring_client_startup(_GApplication*) (ring_client.cpp:441)
==3636==    by 0x70561D3: _g_closure_invoke_va (gclosure.c:867)
==3636==    by 0x70709A5: g_signal_emit_valist (gsignal.c:3294)
==3636==    by 0x707108E: g_signal_emit (gsignal.c:3441)
==3636==    by 0x6D6B0B1: g_application_register (gapplication.c:2049)
==3636==  Block was alloc'd at
==3636==    at 0x4C2BBCF: malloc (vg_replace_malloc.c:299)
==3636==    by 0x7658AA1: QArrayData::allocate(unsigned long, unsigned long, unsigned long, QFlags<QArrayData::AllocationOption>) (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.6.1)
==3636==    by 0x765B2AF: QByteArray::QByteArray(int, Qt::Initialization) (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.6.1)
==3636==    by 0x76E8744: QString::toLatin1_helper(QChar const*, int) (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.6.1)
==3636==    by 0x76E878F: QString::toLatin1_helper(QString const&) (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.6.1)
==3636==    by 0x505EEBC: toLatin1 (qstring.h:509)
==3636==    by 0x505EEBC: Interfaces::DBusErrorHandlerDefault::invalidInterfaceError(QString const&) (dbuserrorhandlerdefault.cpp:33)
==3636==    by 0x505C605: VideoManager::instance() (videomanager.cpp:42)
==3636==    by 0x506A1BE: VideoRendererManager::VideoRendererManager() (videorenderermanager.cpp:84)
==3636==    by 0x506A394: VideoRendererManager::instance() (videorenderermanager.cpp:98)
==3636==    by 0x4F8AF02: CallModel::CallModel() (callmodel.cpp:155)
==3636==    by 0x4F9204C: CallModel::instance() (callmodel.cpp:132)
==3636==    by 0x12ED18: ring_client_startup(_GApplication*) (ring_client.cpp:441)
==3636== 

** (gnome-ring:3636): WARNING **: Error : dring is not available, make sure it is running
==3636== Invalid read of size 1
==3636==    at 0xF19B642: _IO_default_xsputn (genops.c:455)
==3636==    by 0xF170C5A: vfprintf (vfprintf.c:1632)
==3636==    by 0xF220044: __vasprintf_chk (vasprintf_chk.c:66)
==3636==    by 0x7326CE8: vasprintf (stdio2.h:210)
==3636==    by 0x7326CE8: g_vasprintf (gprintf.c:316)
==3636==    by 0x730167C: g_strdup_vprintf (gstrfuncs.c:514)
==3636==    by 0x55847AE: gtk_message_dialog_new (in /usr/lib/x86_64-linux-gnu/libgtk-3.so.0.2000.6)
==3636==    by 0x12D9A7: init_exception_dialog(char const*) (ring_client.cpp:132)
==3636==    by 0x12F78A: ring_client_startup(_GApplication*) (ring_client.cpp:443)
==3636==    by 0x70561D3: _g_closure_invoke_va (gclosure.c:867)
==3636==    by 0x70709A5: g_signal_emit_valist (gsignal.c:3294)
==3636==    by 0x707108E: g_signal_emit (gsignal.c:3441)
==3636==    by 0x6D6B0B1: g_application_register (gapplication.c:2049)
==3636==  Address 0x205e8d81 is 49 bytes inside a block of size 80 free'd
==3636==    at 0x4C2CDFB: free (vg_replace_malloc.c:530)
==3636==    by 0x505EED1: Interfaces::DBusErrorHandlerDefault::invalidInterfaceError(QString const&) (dbuserrorhandlerdefault.cpp:33)
==3636==    by 0x505C605: VideoManager::instance() (videomanager.cpp:42)
==3636==    by 0x506A1BE: VideoRendererManager::VideoRendererManager() (videorenderermanager.cpp:84)
==3636==    by 0x506A394: VideoRendererManager::instance() (videorenderermanager.cpp:98)
==3636==    by 0x4F8AF02: CallModel::CallModel() (callmodel.cpp:155)
==3636==    by 0x4F9204C: CallModel::instance() (callmodel.cpp:132)
==3636==    by 0x12ED18: ring_client_startup(_GApplication*) (ring_client.cpp:441)
==3636==    by 0x70561D3: _g_closure_invoke_va (gclosure.c:867)
==3636==    by 0x70709A5: g_signal_emit_valist (gsignal.c:3294)
==3636==    by 0x707108E: g_signal_emit (gsignal.c:3441)
==3636==    by 0x6D6B0B1: g_application_register (gapplication.c:2049)
==3636==  Block was alloc'd at
==3636==    at 0x4C2BBCF: malloc (vg_replace_malloc.c:299)
==3636==    by 0x7658AA1: QArrayData::allocate(unsigned long, unsigned long, unsigned long, QFlags<QArrayData::AllocationOption>) (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.6.1)
==3636==    by 0x765B2AF: QByteArray::QByteArray(int, Qt::Initialization) (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.6.1)
==3636==    by 0x76E8744: QString::toLatin1_helper(QChar const*, int) (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.6.1)
==3636==    by 0x76E878F: QString::toLatin1_helper(QString const&) (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.6.1)
==3636==    by 0x505EEBC: toLatin1 (qstring.h:509)
==3636==    by 0x505EEBC: Interfaces::DBusErrorHandlerDefault::invalidInterfaceError(QString const&) (dbuserrorhandlerdefault.cpp:33)
==3636==    by 0x505C605: VideoManager::instance() (videomanager.cpp:42)
==3636==    by 0x506A1BE: VideoRendererManager::VideoRendererManager() (videorenderermanager.cpp:84)
==3636==    by 0x506A394: VideoRendererManager::instance() (videorenderermanager.cpp:98)
==3636==    by 0x4F8AF02: CallModel::CallModel() (callmodel.cpp:155)
==3636==    by 0x4F9204C: CallModel::instance() (callmodel.cpp:132)
==3636==    by 0x12ED18: ring_client_startup(_GApplication*) (ring_client.cpp:441)
==3636== 
Gtk-Message: GtkDialog mapped without a transient parent. This is discouraged.

** (gnome-ring:3636): ERROR **: Error : dring is not available, make sure it is running
==3636== 
==3636== Process terminating with default action of signal 5 (SIGTRAP)
==3636==    at 0x72E9A6B: _g_log_abort (gmessages.c:325)
==3636==    by 0x72E9A6B: g_logv (gmessages.c:1080)
==3636==    by 0x72E9BDE: g_log (gmessages.c:1119)
==3636==    by 0x12F7A2: ring_client_startup(_GApplication*) (ring_client.cpp:444)
==3636==    by 0x70561D3: _g_closure_invoke_va (gclosure.c:867)
==3636==    by 0x70709A5: g_signal_emit_valist (gsignal.c:3294)
==3636==    by 0x707108E: g_signal_emit (gsignal.c:3441)
==3636==    by 0x6D6B0B1: g_application_register (gapplication.c:2049)
==3636==    by 0x6D6B8DE: g_application_real_local_command_line (gapplication.c:1012)
==3636==    by 0x6D6BC41: g_application_run (gapplication.c:2350)
==3636==    by 0xF14972F: (below main) (libc-start.c:291)
==3636== 
==3636== HEAP SUMMARY:
==3636==     in use at exit: 24,772,280 bytes in 34,023 blocks
==3636==   total heap usage: 201,100 allocs, 167,077 frees, 58,605,119 bytes allocated
==3636== 
==3636== LEAK SUMMARY:
==3636==    definitely lost: 26,664 bytes in 50 blocks
==3636==    indirectly lost: 784,653 bytes in 3,775 blocks
==3636==      possibly lost: 21,862,503 bytes in 5,536 blocks
==3636==    still reachable: 1,995,404 bytes in 23,858 blocks
==3636==                       of which reachable via heuristic:
==3636==                         length64           : 5,616 bytes in 96 blocks
==3636==                         newarray           : 2,192 bytes in 57 blocks
==3636==         suppressed: 0 bytes in 0 blocks
==3636== Rerun with --leak-check=full to see details of leaked memory
==3636== 
==3636== For counts of detected and suppressed errors, rerun with: -v
==3636== ERROR SUMMARY: 333 errors from 4 contexts (suppressed: 0 from 0)
Killed

This look like something that should not happen.  Note how the error
message showed up as it should when executed using valgrind, but not
outside valgrind.

-- 
Happy hacking
Petter Reinholdtsen