Bug#843654: Use Debian pjproject and libsrtp

[Andrey Gursky]

Hi Tzafrir, hi Bernhard, hi Alexandre

On Tue, 8 Nov 2016 16:24:58 +0100 Tzafrir Cohen wrote:

> On Tue, Nov 08, 2016 at 04:15:49PM +0100, Andrey Gursky wrote:
> > Source: ring
> > Version: 20161104.4.17a0616~dfsg1-2
> > Severity: normal
> > 
> > Dear maintainer,
> > 
> > A week ago pjproject 2.5.5 has been made available in Debian. The same
> > as in ring-daemon contribs. However ring applies following patches:
> > endianness.patch
> > gnutls.patch
> > notestsapps.patch
> > ipv6.patch
> > ice_config.patch
> > multiple_listeners.patch
> > pj_ice_sess.patch
> > fix_turn_fallback.patch
> > fix_ioqueue_ipv6_sendto.patch
> > 
> > The biggest one gnutls.patch can be dropped, since packaged pjproject
> > can dynamically link to a SSL library. Is the rest important? If not,
> > then the packaged pjproject could be used already. If not, is pjproject
> > not really usable without them? Then they should be forwarded upstream
> > and for now applied in the packaged pjproject. Or there are some issues
> > with that? Please share the current status.
> 
> For the record, pjproject is currently used by a single other package:
> asterisk. Upstream of asterisk recommends applying a set of their own
> patches:
> 
> http://git.asterisk.org/gitweb/?p=asterisk/asterisk.git;a=tree;f=third-party/pjproject/patches;hb=13

Tzafrir, thanks for pointing this out. I've just noticed that these
patches have been included in pjproject.

Bernhard, what do you think about including the bug-fix patches from
the Ring's pjproject also? For the same reasons as for Asterisk [1]:

> This is not allowed or severely disencouraged in most distributions, for
> very good reasons.
>
> https://fedoraproject.org/wiki/Bundled_Libraries
> https://www.debian.org/doc/debian-policy/ch-source.html#s-embeddedfiles

Alexandre, could you please add "forwarded upstream" links for each of
these patches and what Ring bugs are they suppose to fix?

Thanks,
Andrey

[1] http://lists.pjsip.org/pipermail/pjsip_lists.pjsip.org/2016-November/019650.html