twinkle 1.10.1

Peter Colberg peter at colberg.org
Fri Oct 28 03:47:49 UTC 2016


On Thu, Oct 27, 2016 at 11:37:32PM -0400, Peter Colberg wrote:
> Hi Rolf,
> 
> After reading the message by Alexey to pkg-voip regarding twinkle I
> pulled the repository to see that you have already prepared it :-).
> 
> I noticed that the new tarball does not match the upstream tarball
> as created by `uscan --rename`. How did you create the orig tarball?
> 
> # pristine-tar checkout ../twinkle_1.10.1+dfsg.orig.tar.gz
> # sha256sum ../twinkle_1.10.1+dfsg.orig.tar.gz
> b95974e09062bb9c5e7c257788df178895f9a94324b057aad4ff7e8101de91f4  ../twinkle_1.10.1+dfsg.orig.tar.gz
> 
> # uscan --rename
> # sha256sum ../twinkle_1.10.1+dfsg.orig.tar.gz
> acc37673941b48604425e524232d50cd5fecd7756cae14e220daf1a8edce75f5  ../twinkle_1.10.1+dfsg.orig.tar.gz
> 
> For the commit messages I would suggest to omit the preceding filename
> (e.g. omit "control: ") and capitalize the first word, since it is
> usually clear which file is changed and makes for a nicer changelog.

Two minor points:

  * Add an explicit build dependency on ucommon
  * Run wrap-and-sort

Peter



More information about the Pkg-voip-maintainers mailing list