twinkle 1.10.1

Rolf Leggewie foss at rolf.leggewie.biz
Sat Oct 29 11:52:42 UTC 2016


Peter,

thank you for your mails.  My apologies for not responding sooner.

On 29.10.2016 06:06, Peter Colberg wrote:
> I have cleaned up the commit messages for the changelog

Well, I do not mention the files out of boredom.  I've been a long-time
DM and found that information to be helpful.  I do not think it will
interfere with your style and do not intend to change the style for my
good dozen packages.  Only other option would be to use two different
commit styles and frankly, I think that's far too much trouble.  I hope
you won't mind.

There's nothing "dirty" about my style so certainly no cleaning needed.

Case in point of filenames being helpful information; your commit
c198607bc.  "Bump debhelper compat level to 10" would have never led me
to believe that you would touch debian/rules to drop the parallel
building.  Frankly, I think that should have been an atomic commit of
its own.  Why did you drop it after all?  It seems to have worked fine here.

> and committed
> a reproducible tarball. Instead of manually packaging a tarball with
> random timestamps and file order, please use uscan next time, which
> also takes care of excluding the files mentioned in debian/copyright.

My tarball IS reproducible, apparently just differently from your
setup.  I did use uscan and gbp as requested.  My main machine runs
Ubuntu trusty and I think you might be relying on a feature that was
only introduced later.  I noticed now that I do get an error like

$ uscan --report
uscan warning: unrecognised option repacksuffix=+dfsg
$

BTW, "Explicitly build depend on libucommon-dev" has a very different
meaning from "Explicitly build-depend on libucommon-dev".  It should
have been the latter in the changelog but too late now.

Thanks for the upload.

Best regards

Rolf



More information about the Pkg-voip-maintainers mailing list