Bug#861236: portaudio19 should build-depend on pkg-config

[Jonas Smedegaard]

Control: severity -1 important

Quoting Andrew Shadura (2017-04-27 10:52:23)
> Control: severity -1 minor
> 
> On 27 April 2017 at 10:50, Bernhard Schmidt <berni at birkenwald.de> wrote:
> > On 26.04.2017 13:37, Andrew Shadura wrote:
> >> Since portaudio19 package uses autoreconf, it should build-depend 
> >> on pkg-config package. Without that dependency, it fails to 
> >> reconfigure itself:
> >>
> >> ./configure: line 16045: syntax error near unexpected token `JACK,'
> >> ./configure: line 16045: `    PKG_CHECK_MODULES(JACK, jack, have_jack=yes, have_jack=no)'
> >>     "tail -v -n +0 config.log"
> >>
> 
>> Hrm, I'm a bit unsure why you would need this, as it is already 
>> pulled in. portaudio19 build-depends on libjack-dev, and libjack-dev 
>> depends on pkg-config, so it should already be there. Also the buildd 
>> logs show that it is getting installed.
> 
> Right, we’re building it without JACK, that’s why. In any case, an 
> explicit dependency is better than an implicit.

Lowering severity to minor is wrong:

Policy §4.2 dictates that a package should declare all direct 
build.dependencies - not rely on transitive build-depenendies because 
those may change and such changes outside of the package should not 
affect this package.


 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-voip-maintainers/attachments/20170427/8a9bacaa/attachment-0001.sig>