Bug#888601: iaxmodem: FTBFS with debhelper/11.1 due to empty build target

[Niels Thykier]

Package: iaxmodem
Version: 1.2.0~dfsg-2
Severity: serious
Tags: patch

Hi,

The iaxmodem package FTBFS with debhelper/11.1 as it has an empty
build target.  This is caused by debhelper had a bug in its handling
of "explicitly defined rules targets" that has now been fixed.

Previously, this happened to work because dpkg-buildpackage would
invoke "debian/rules build" (which would be a no-op) followed by
"fakeroot debian/rules binary".  During the binary target, dh's
suboptimal handling would run the build commands.


The solution is trivial but less pretty; explicitly define "build"
with the same content as the "%:" target (or rename the "build" folder
and drop the ".PHONY" target).  I have attached a patch for this.

There is also an optional patch (0002) that removes the now deprecated
"autotools-dev" sequence.  The default dh sequence replaces it without
any (additional) changes required in Debian stable and
oldstable-backports.


More details can be found in:
 * #886901 comment #35
 * #887688 comment #37
 * #880840

Apologies for the inconvenience.

Thanks,
~Niels
-------------- next part --------------
>From 564d7a1e68b082e63e0e1dc9c0009e9498428e79 Mon Sep 17 00:00:00 2001
From: Niels Thykier <niels at thykier.net>
Date: Sat, 27 Jan 2018 15:40:03 +0000
Subject: [PATCH 1/2] Avoid empty build target

The dh sequencer as of debhelper/11.1 is stricter with this in order
to solve #880840 (where debhelper would fail to handle such targets
correctly).

Signed-off-by: Niels Thykier <niels at thykier.net>
---
 debian/rules | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/debian/rules b/debian/rules
index 3ed5dd9..f3d0450 100755
--- a/debian/rules
+++ b/debian/rules
@@ -40,6 +40,11 @@ URL := http://heanet.dl.sourceforge.net/iaxmodem/iaxmodem-$(UPVERSION).tar.gz
 %:
 	dh $@ --with-autotools_dev
 
+# The build target must not be empty.  Sadly because of how make
+# works, we have do duplicate the target in this case.
+build:
+	dh $@ --with-autotools_dev
+
 override_dh_auto_configure:
 	# Check that problematic files have been removed prior to packaging
 	( [ ! -e lib/spandsp/src/spandsp/mmx.h ] && \
-- 
2.15.1

-------------- next part --------------
>From 0ff7844ebf40bd23c51662cbd0c66e232d87be4b Mon Sep 17 00:00:00 2001
From: Niels Thykier <niels at thykier.net>
Date: Sat, 27 Jan 2018 16:05:36 +0000
Subject: [PATCH 2/2] Drop deprecated autotools-dev sequence

Signed-off-by: Niels Thykier <niels at thykier.net>
---
 debian/control | 2 +-
 debian/rules   | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/debian/control b/debian/control
index 95dde20..a8df0cf 100644
--- a/debian/control
+++ b/debian/control
@@ -3,7 +3,7 @@ Section: comm
 Priority: optional
 Maintainer: Debian VoIP Team <pkg-voip-maintainers at lists.alioth.debian.org>
 Uploaders: Tzafrir Cohen <tzafrir at debian.org>
-Build-Depends: debhelper (>= 9), libtiff-dev | libtiff4-dev, autotools-dev
+Build-Depends: debhelper (>= 9), libtiff-dev | libtiff4-dev
 Build-Conflicts: libiax-dev, libspandsp-dev
 Standards-Version: 3.8.0
 Homepage: http://iaxmodem.sourceforge.net/
diff --git a/debian/rules b/debian/rules
index f3d0450..49df162 100755
--- a/debian/rules
+++ b/debian/rules
@@ -38,12 +38,12 @@ UPFILENAME := iaxmodem_$(UPVERSION).orig.tar.gz
 URL := http://heanet.dl.sourceforge.net/iaxmodem/iaxmodem-$(UPVERSION).tar.gz
 
 %:
-	dh $@ --with-autotools_dev
+	dh $@
 
 # The build target must not be empty.  Sadly because of how make
 # works, we have do duplicate the target in this case.
 build:
-	dh $@ --with-autotools_dev
+	dh $@
 
 override_dh_auto_configure:
 	# Check that problematic files have been removed prior to packaging
-- 
2.15.1