Bug#903475: sipsak: MD5 auth broken

Bastian Triller bastian.triller at gmail.com
Tue Jul 10 13:46:42 BST 2018


Package: sipsak
Version: 0.9.6+git20160713-2
Severity: important
Tags: patch

Dear Maintainer,


using sipsak with a proxy, that challenges the UA for credentials, does not
(always?) work e.g. to REGISTER:

sipsak -U --password secret -s sip:myuser at domain

This bug was fixed upstream [1].

Please integrate attached patch.

Thank you.

[1] https://github.com/nils-
ohlmeier/sipsak/commit/a43f1389114b1144009ac814d93f6fb31241e047



-- System Information:
Debian Release: buster/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (101, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.17.0-rc3-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
-------------- next part --------------
>From a43f1389114b1144009ac814d93f6fb31241e047 Mon Sep 17 00:00:00 2001
From: Walter Doekes <walter+github at wjd.nu>
Date: Mon, 13 Mar 2017 11:25:56 +0100
Subject: [PATCH] Fix MD5 auth calculation on many 64-bit systems.

Unsigned long is very often 8 bytes, not 4. Use stdint.h if available.
---
 md5global.h | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/md5global.h b/md5global.h
index 1040d8d..a29df5c 100644
--- a/md5global.h
+++ b/md5global.h
@@ -15,11 +15,13 @@ The following makes PROTOTYPES default to 0 if it has not already
 /* POINTER defines a generic pointer type */
 typedef unsigned char *POINTER;
 
-/* UINT2 defines a two byte word */
-typedef unsigned short int UINT2;
-
+#ifdef HAVE_STDINT_H
+# include <stdint.h>
+typedef uint32_t UINT4;
+#else
 /* UINT4 defines a four byte word */
 typedef unsigned long int UINT4;
+#endif
 
 /* PROTO_LIST is defined depending on how PROTOTYPES is defined above.
 If using PROTOTYPES, then PROTO_LIST returns the list, otherwise it


More information about the Pkg-voip-maintainers mailing list