Bug#911358: libre hard codes location of C headers

Helmut Grohne helmut at subdivi.de
Fri Oct 19 04:54:24 BST 2018


Source: libre
Version: 0.5.9-1
Tags: patch upstream
Control: block 798955 by -1

libre checks for header existence by searching them in a few filesystem
locations. Debian's /usr/include/<triplet> is not always among those
locations and that makes libre fail to build when built against a
non-glibc or a glibc with multiarch headers (#798955). The attached
multiarch-libc.patch replaces those file existence tests with compile
tests. The compiler knows much better whether headers exists.

Once doing this, you notice that the SYSROOT variable is unused and you
can as well remove it (remove-sysroot.patch). Once removing SYSROOT, you
notice that MACHINE is mostly unused: The only use is setting up
CROSS_COMPILE and OS, but these are supposed to be set by a user for
cross compilation. Removing this code makes win32 behave just like any
other arch and MACHINE can go in the bucket as well
(remove-machine.patch). This simplification is entirely optional of
course.

Please consider applying at least multiarch-libc.patch and close this
bug when doing so.

Helmut
-------------- next part --------------
A non-text attachment was scrubbed...
Name: multiarch-libc.patch
Type: text/x-diff
Size: 4130 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-voip-maintainers/attachments/20181019/be4d1c3c/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: remove-sysroot.patch
Type: text/x-diff
Size: 1092 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-voip-maintainers/attachments/20181019/be4d1c3c/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: remove-machine.patch
Type: text/x-diff
Size: 1009 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-voip-maintainers/attachments/20181019/be4d1c3c/attachment-0002.patch>


More information about the Pkg-voip-maintainers mailing list