Bug#957470: libpri: ftbfs with GCC-10

[Matthias Klose]

Package: src:libpri
Version: 1.6.0-1
Severity: normal
Tags: sid bullseye
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-10

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-10/g++-10, but succeeds to build with gcc-9/g++-9. The
severity of this report will be raised before the bullseye release,
so nothing has to be done for the buster release.

The full build log can be found at:
http://people.debian.org/~doko/logs/gcc10-20200225/libpri_1.6.0-1_unstable_gcc10.log
The last lines of the build log are at the end of this report.

To build with GCC 10, either set CC=gcc-10 CXX=g++-10 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-10/porting_to.html

[...]
                 from q921.c:38:
pri_q921.h:136:11: note: while referencing ‘data’
  136 |  u_int8_t data[0];  /* Any further data */
      |           ^~~~
q921.c:1528:15: error: array subscript 1 is outside the bounds of an interior zero-length array ‘u_int8_t[0]’ {aka ‘unsigned char[0]’} [-Werror=zero-length-bounds]
 1528 |  ri = (h->data[1] << 8) | h->data[2];
      |        ~~~~~~~^~~
In file included from pri_internal.h:35,
                 from q921.c:38:
pri_q921.h:136:11: note: while referencing ‘data’
  136 |  u_int8_t data[0];  /* Any further data */
      |           ^~~~
q921.c:1528:34: error: array subscript 2 is outside the bounds of an interior zero-length array ‘u_int8_t[0]’ {aka ‘unsigned char[0]’} [-Werror=zero-length-bounds]
 1528 |  ri = (h->data[1] << 8) | h->data[2];
      |                           ~~~~~~~^~~
In file included from pri_internal.h:35,
                 from q921.c:38:
pri_q921.h:136:11: note: while referencing ‘data’
  136 |  u_int8_t data[0];  /* Any further data */
      |           ^~~~
q921.c:1529:16: error: array subscript 4 is outside the bounds of an interior zero-length array ‘u_int8_t[0]’ {aka ‘unsigned char[0]’} [-Werror=zero-length-bounds]
 1529 |  tei = (h->data[4] >> 1);
      |         ~~~~~~~^~~
In file included from pri_internal.h:35,
                 from q921.c:38:
pri_q921.h:136:11: note: while referencing ‘data’
  136 |  u_int8_t data[0];  /* Any further data */
      |           ^~~~
q921.c:1531:17: error: array subscript 3 is outside the bounds of an interior zero-length array ‘u_int8_t[0]’ {aka ‘unsigned char[0]’} [-Werror=zero-length-bounds]
 1531 |  switch (h->data[3]) {
      |          ~~~~~~~^~~
In file included from pri_internal.h:35,
                 from q921.c:38:
pri_q921.h:136:11: note: while referencing ‘data’
  136 |  u_int8_t data[0];  /* Any further data */
      |           ^~~~
q921.c:1606:12: error: array subscript 4 is outside the bounds of an interior zero-length array ‘u_int8_t[0]’ {aka ‘unsigned char[0]’} [-Werror=zero-length-bounds]
 1606 |   action = &h->data[4];
      |            ^~~~~~~~~~~
In file included from pri_internal.h:35,
                 from q921.c:38:
pri_q921.h:136:11: note: while referencing ‘data’
  136 |  u_int8_t data[0];  /* Any further data */
      |           ^~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:174: q921.o] Error 1
make[1]: *** Waiting for unfinished jobs....
q931.c: In function ‘q931_receive’:
q931.c:7688:25: error: array subscript 17 is outside the bounds of an interior zero-length array ‘unsigned char[0]’ [-Werror=zero-length-bounds]
 7688 |    h->raw[h->crlen + 2] -= 0x8;
      |                         ^~
In file included from pri_internal.h:36,
                 from q931.c:32:
pri_q931.h:40:16: note: while referencing ‘raw’
   40 |  unsigned char raw[0];
      |                ^~~
q931.c:7688:25: error: array subscript 17 is outside the bounds of an interior zero-length array ‘unsigned char[0]’ [-Werror=zero-length-bounds]
 7688 |    h->raw[h->crlen + 2] -= 0x8;
      |    ~~~~~~~~~~~~~~~~~~~~~^~~~~~
In file included from pri_internal.h:36,
                 from q931.c:32:
pri_q931.h:40:16: note: while referencing ‘raw’
   40 |  unsigned char raw[0];
      |                ^~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:174: q931.o] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: error: make -j4 returned exit code 2
make: *** [debian/rules:17: build] Error 25
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2