Bug#975854: mediastreamer2: FTBFS: string_fortified.h:106:10: error: ‘__builtin_strncpy’ specified bound 8 equals destination size [-Werror=stringop-truncation]

[Lucas Nussbaum]

Source: mediastreamer2
Version: 1:2.16.1-4
Severity: serious
Justification: FTBFS on amd64
Tags: bullseye sid ftbfs
Usertags: ftbfs-20201125 ftbfs-bullseye

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

Relevant part (hopefully):
> cd /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/src && /usr/bin/cc -DBCTBX_STATIC -DBZRTP_STATIC -DHAVE_CONFIG_H -DMS2_EXPORTS -DMS2_FILTERS -DMS2_INTERNAL -DMS2_STATIC -DORTP_STATIC -DVIDEO_ENABLED -D_TRUE_TIME -Dmediastreamer_base_EXPORTS -I/<<PKGBUILDDIR>>/include -I/<<PKGBUILDDIR>>/src/audiofilters -I/<<PKGBUILDDIR>>/src/utils -I/<<PKGBUILDDIR>>/src/voip -I/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu -I/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/src -I/usr/include/libxml2 -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC  -Wall -Wuninitialized -Wno-format-truncation -Werror -Wextra -Wno-unused-parameter -fno-strict-aliasing -Wno-missing-field-initializers -Wdeclaration-after-statement -Wstrict-prototypes -Wno-error=strict-prototypes -o CMakeFiles/mediastreamer_base.dir/otherfilters/void.c.o -c /<<PKGBUILDDIR>>/src/otherfilters/void.c
> In file included from /usr/include/string.h:495,
>                  from /usr/include/bctoolbox/port.h:38,
>                  from /<<PKGBUILDDIR>>/include/mediastreamer2/mscommon.h:22,
>                  from /<<PKGBUILDDIR>>/include/mediastreamer2/msfilter.h:23,
>                  from /<<PKGBUILDDIR>>/include/mediastreamer2/mstonedetector.h:24,
>                  from /<<PKGBUILDDIR>>/src/audiofilters/tonedetector.c:25:
> In function ‘strncpy’,
>     inlined from ‘detector_process’ at /<<PKGBUILDDIR>>/src/audiofilters/tonedetector.c:176:8:
> /usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:10: error: ‘__builtin_strncpy’ specified bound 8 equals destination size [-Werror=stringop-truncation]
>   106 |   return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
>       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> [ 22%] Building C object src/CMakeFiles/mediastreamer_voip-static.dir/audiofilters/ulaw.c.o
> cd /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/src && /usr/bin/cc -DBCTBX_STATIC -DBZRTP_STATIC -DHAVE_CONFIG_H -DMS2_EXPORTS -DMS2_FILTERS -DMS2_INTERNAL -DMS2_STATIC -DORTP_STATIC -DVIDEO_ENABLED -D_TRUE_TIME -I/<<PKGBUILDDIR>>/include -I/<<PKGBUILDDIR>>/src/audiofilters -I/<<PKGBUILDDIR>>/src/utils -I/<<PKGBUILDDIR>>/src/voip -I/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu -I/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/src -I/usr/include/libxml2 -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2  -Wall -Wuninitialized -Wno-format-truncation -Werror -Wextra -Wno-unused-parameter -fno-strict-aliasing -Wno-missing-field-initializers -Wdeclaration-after-statement -Wstrict-prototypes -Wno-error=strict-prototypes -o CMakeFiles/mediastreamer_voip-static.dir/audiofilters/ulaw.c.o -c /<<PKGBUILDDIR>>/src/audiofilters/ulaw.c
> [ 23%] Linking C shared library libmediastreamer_base.so
> cc1: all warnings being treated as errors
> cd /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/src && /usr/bin/cmake -E cmake_link_script CMakeFiles/mediastreamer_base.dir/link.txt --verbose=1
> make[3]: *** [src/CMakeFiles/mediastreamer_voip-static.dir/build.make:306: src/CMakeFiles/mediastreamer_voip-static.dir/audiofilters/tonedetector.c.o] Error 1

The full build log is available from:
   http://qa-logs.debian.net/2020/11/25/mediastreamer2_2.16.1-4_unstable.log

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

About the archive rebuild: The rebuild was done on EC2 VM instances from
Amazon Web Services, using a clean, minimal and up-to-date chroot. Every
failed build was retried once to eliminate random failures.