Bug#987309: dahdi-dkms: insufficient dkms dependency

[Andreas Beckmann]

Package: dahdi-dkms
Version: 2.11.1.0.20170917~dfsg-7.3
Severity: serious
Tags: patch
User: debian-qa at lists.debian.org
Usertags: piuparts
Control: found -1 2.11.1.0.20170917~dfsg-7

Hi,

during a test with piuparts I noticed your package fails to upgrade from
'buster'.
It installed fine in 'buster', then the upgrade to 'bullseye' fails.

>From the attached log (scroll to the bottom...):

[...]
  Setting up dahdi-dkms (1:2.11.1.0.20170917~dfsg-7.3~deb11anbe1) ...
  Loading new dahdi-2.11.1.0.20170917~dfsg-7.3~deb11anbe1 DKMS files...
  It is likely that 4.19.0-9-amd64 belongs to a chroot's host
  Building for 4.19.0-16-amd64
  Building initial module for 4.19.0-16-amd64
  Error! Bad return status for module build on kernel: 4.19.0-16-amd64 (x86_64)
  Consult /var/lib/dkms/dahdi/2.11.1.0.20170917~dfsg-7.3~deb11anbe1/build/make.log for more information.
  dpkg: error processing package dahdi-dkms (--configure):
   installed dahdi-dkms package post-installation script subprocess returned error exit status 10
  dpkg: dependency problems prevent configuration of dahdi-linux:
   dahdi-linux depends on dahdi-dkms | dahdi-source; however:
    Package dahdi-dkms is not configured yet.
    Package dahdi-source is not installed.
  
  dpkg: error processing package dahdi-linux (--configure):
   dependency problems - leaving unconfigured
  Processing triggers for libc-bin (2.28-10) ...
  Processing triggers for mime-support (3.62) ...
  Errors were encountered while processing:
   dahdi-dkms
   dahdi-linux

In this upgrade path dahdi-dkms was upgraded before dkms.
This is probably related to the compiler used to build the module.
This can be fixed by bumping the dkms dependency s.t. a dkms version
is used that exports the compiler used to build the kernel (and
depended upon by the kernel headers) as CC.

The version is set s.t. it does not block of the current version in sid.
I'll NMU this fix after the current sid version has migrated to testing.


cheers,

Andreas
-------------- next part --------------
diff -Nru dahdi-linux-2.11.1.0.20170917~dfsg/debian/changelog dahdi-linux-2.11.1.0.20170917~dfsg/debian/changelog
--- dahdi-linux-2.11.1.0.20170917~dfsg/debian/changelog	2021-04-04 22:42:52.000000000 +0200
+++ dahdi-linux-2.11.1.0.20170917~dfsg/debian/changelog	2021-04-21 10:54:41.000000000 +0200
@@ -1,3 +1,12 @@
+dahdi-linux (1:2.11.1.0.20170917~dfsg-7.4) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * dahdi-dkms: Bump dkms dependency to (>= 2.8.4-3~) to reliably use the
+    kernel's compiler to compile the module.  (Closes: #-1)
+  * dahdi-dkms: Drop wget dependency. Downloading firmware is disabled.
+
+ -- Andreas Beckmann <anbe at debian.org>  Wed, 21 Apr 2021 10:54:41 +0200
+
 dahdi-linux (1:2.11.1.0.20170917~dfsg-7.3) unstable; urgency=medium
 
   * Non-maintainer upload.
diff -Nru dahdi-linux-2.11.1.0.20170917~dfsg/debian/control dahdi-linux-2.11.1.0.20170917~dfsg/debian/control
--- dahdi-linux-2.11.1.0.20170917~dfsg/debian/control	2021-04-02 22:51:16.000000000 +0200
+++ dahdi-linux-2.11.1.0.20170917~dfsg/debian/control	2021-04-21 10:54:41.000000000 +0200
@@ -18,7 +18,7 @@
 Multi-Arch: foreign
 Depends: ${misc:Depends}, procps, fxload, dahdi-dkms | dahdi-source
 Description: DAHDI telephony interface - Linux userspace parts
- DAHDI (formly Zaptel) is an interface for telephony devices used by e.g.
+ DAHDI (formerly Zaptel) is an interface for telephony devices used by e.g.
  the Asterisk PBX software. The dahdi-* packages provide the kernel
  DAHDI kernel modules and their required setup environment.
  .
@@ -32,7 +32,7 @@
 Depends: ${misc:Depends}, debhelper (>> 4.0), module-assistant (>= 0.8.1), bzip2
 Recommends: dahdi-linux
 Description: DAHDI telephony interface - source code for kernel driver
- DAHDI (formly Zaptel) is an interface for telephony devices used by e.g.
+ DAHDI (formerly Zaptel) is an interface for telephony devices used by e.g.
  the Asterisk PBX software. The dahdi-* packages provide the kernel
  DAHDI kernel modules and their required setup environment, as well as
  basic headers for building DAHDI modules and utilities.
@@ -42,10 +42,10 @@
 Package: dahdi-dkms
 Section: kernel
 Architecture: all
-Depends: ${misc:Depends}, dkms, make, libc6-dev, dpkg-dev, gcc, wget, gawk
+Depends: ${misc:Depends}, dkms, make, libc6-dev, dpkg-dev, gcc, gawk, dkms (>= 2.8.4-3~)
 Recommends: dahdi-linux
 Description: DAHDI telephony interface (dkms kernel driver)
- DAHDI (formly Zaptel) is an interface for telephony devices used by e.g.
+ DAHDI (formerly Zaptel) is an interface for telephony devices used by e.g.
  the Asterisk PBX software. The dahdi-* packages provide the kernel
  DAHDI kernel modules and their required setup environment.
  .