Bug#983365: linphone-desktop: chat messages

[Bernhard Schmidt]

Hi Dennis,

thanks a lot for debugging this! BTW, linphone is in desperate need of
co-maintainers :-)   That's a lot more useful than complaining about the
package not being tested (it is, but I do not know anyone using the Chat
feature, and I certainly don't).

Honestly I don't know why there is ENABLE_DB_STORAGE=NO, it sneaked in
during the packaging attempts. Possibly because libsoci wasn't usable
without the C++11 option you found.

Have you reached out to the SOCI maintainer in private already? I don't
see a bug report on this. If we can get a targeted fix uploaded for this
within the next days (next step of the freeze is on March 10th, with a
migration time of 10 days right now) I will attempt to push through a
new src:linphone upload. Do you know whether we need a new
src:linphone-desktop upload as well?

Have you confirmed already that the whole soci/linphone dance really
fixes this issue?

Bernhard

Am 25.02.21 um 18:58 schrieb Dennis Filder:
> Control: tag -1 + confirmed sid bullseye
> 
> I looked into this the past days, and I think this is actually a bug
> in d/rules in src:linphone.  I'm beginning to suspect that this is due
> to this line:
> 
> 		-DENABLE_DB_STORAGE=NO \
> 
> Apparently the code for the once separate chat history and call
> history DBs has been merged into a single DB with special logic to
> handle the migration -- since I have no files from a previous version
> linphone-desktop 4.2.5 here does not even create anymore the sqlite3
> database linphone.db in ~/.local/share/linphone/ that David mentions,
> only call-history.db and friends.db are created (which matches the
> source code).  However, if the database storage isn't configured and
> compiled in then that new database is not going to work of course.
> Was there a specific reason for disabling this?  I could get
> linphone-4.4.21 to build with -DENABLE_DB_STORAGE=YES, but I had to
> first build+install a version of libsoci-dev that was compiled with
> -DSOCI_CXX11=YES.  I'll contact the soci maintainer to see if he can
> change that in time.
> 
> linphone-4.4.21/cmake/FindSoci.cmake calls the soci support
> experimental, but the official appimage ships with both libsoci_core.0
> and libsoci_sqlite3.0, so it should be stable enough for us, too.
> That warning is probably outdated.  I attached a diff of the linked-in
> shared libraries in Debian's and the AppImage's /usr/bin/linphone
> (4.2.5) to illustrate where else we deviate.
> 
> Another issue I ran into: during dh_auto_configure a CMake macro tries
> to invoke "git describe" to look up the tag for the build's branch.
> Setting GIT_EXECUTABLE to a shell script that emits the expected tag
> worked around that.  I used $(shell pwd) there to point to the script,
> but I don't know if this is the right way to do it.  Fix it if it's
> wrong.
> 
> I'll keep digging into this and let you know if I learn something new.
> 
> Regards,
> Dennis
>