Bug#979747: rtpproxy: FTBFS with GCC 10

[Logan Rosen]

Package: rtpproxy
Version: 1.2.1-2.2
Severity: serious
Tags: patch ftbfs
Justification: fails to build from source (but built successfully in the past)
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu hirsute ubuntu-patch
X-Debbugs-Cc: logan at ubuntu.com

Hi,

rtpproxy currently FTBFS in Debian unstable with GCC 10 as default.

>From a local build:
gcc -std=gnu99 -Wall -Wno-uninitialized -g -O2 -ffile-prefix-map=/build/rtpproxy
-1.2.1=. -fstack-protector-strong -Wformat -Werror=format-security  -Wl,-z,relro
 -Wl,-z,now -o rtpproxy main.o rtp_server.o rtpp_record.o rtpp_util.o rtp.o rtp_
resizer.o rtpp_session.o rtpp_command.o rtpp_log.o rtpp_syslog_async.o -lm -lpth
read
/usr/bin/ld: rtpp_record.o:./rtpp_record.h:84: multiple definition of `__packed'
; main.o:./rtpp_record.h:84: first defined here
/usr/bin/ld: rtpp_session.o:./rtpp_record.h:84: multiple definition of `__packed
'; main.o:./rtpp_record.h:84: first defined here
/usr/bin/ld: rtpp_command.o:./rtpp_record.h:84: multiple definition of `__packed
'; main.o:./rtpp_record.h:84: first defined here
collect2: error: ld returned 1 exit status
make[2]: *** [Makefile:455: rtpproxy] Error 1
make[2]: Leaving directory '/build/rtpproxy-1.2.1'
make[1]: *** [Makefile:354: all] Error 2
make[1]: Leaving directory '/build/rtpproxy-1.2.1'
dh_auto_build: error: make -j8 returned exit code 2
make: *** [debian/rules:6: build] Error 25

In Ubuntu, the attached patch was applied to achieve the following:

  * d/p/gcc-10.patch: Fix compilation with GCC 10.

Thanks for considering the patch.

Logan
-------------- next part --------------
diff -Nru rtpproxy-1.2.1/debian/patches/gcc-10.patch rtpproxy-1.2.1/debian/patches/gcc-10.patch
--- rtpproxy-1.2.1/debian/patches/gcc-10.patch	1969-12-31 19:00:00.000000000 -0500
+++ rtpproxy-1.2.1/debian/patches/gcc-10.patch	2021-01-10 20:42:24.000000000 -0500
@@ -0,0 +1,11 @@
+--- a/rtpp_record.h
++++ b/rtpp_record.h
+@@ -81,7 +81,7 @@
+     uint32_t family;
+     struct ip iphdr;
+     struct udphdr udphdr;
+-} __packed;
++};
+ 
+ struct pkt_hdr_adhoc {
+     union sockaddr_in_s addr;   /* Source address */
diff -Nru rtpproxy-1.2.1/debian/patches/series rtpproxy-1.2.1/debian/patches/series
--- rtpproxy-1.2.1/debian/patches/series	2014-02-15 22:57:22.000000000 -0500
+++ rtpproxy-1.2.1/debian/patches/series	2021-01-10 20:38:05.000000000 -0500
@@ -1 +1,2 @@
 syslog_format.patch
+gcc-10.patch