Bug#983365: [PATCH] Re: Bug#983365: linphone-desktop: chat messages

[Bernhard Schmidt]

Am 03.03.21 um 18:55 schrieb Dennis Filder:

Hi Dennis,

> On Sun, Feb 28, 2021 at 11:07:31PM +0100, Bernhard Schmidt wrote:
>> an updated liblinphone has been uploaded to sid yesterday. Could you
>> please try liblinphone10 and liblinphone++10 from sid (4.4.21-2) and
>> report back? If it does not work you might need libsoci-core4.0 and
>> libsoci-sqlite3-4.0 from unstable as well (4.0.1-4).
> 
> I finally found the bug: libsoci_sqlite3 sometimes returns string
> where liblinphone unconditionally expects int, long, double etc. which
> led to silent std::bad_cast exceptions.  I can't say who is actually
> to blame (I feel soci should do that conversion already as it knows
> what type the user requested, or at least not throw silently), but the
> attached patches remedy the issue through some conditional string
> conversion and make chat history actually work again in the GUI.  They
> should really have separated the sqlite3 database code better from the
> MySQL code.
> 
> I put this in two separate patches to make it easier to remove the
> changes to the code for the legacy DB migration in case it causes
> problems.

Cool, thanks. Would you mind discussing your findings with upstream at
https://gitlab.linphone.org/BC/public/liblinphone ? We will need a
freeze exception for this, having this bug confirmed by upstream would
help a lot, cherry-picking a commit from upstream would be even better.

Right now I don't plan to upload src:linphone before 4.4.21-2 has
migrated to testing, in order to have a minimum amount of changes to be
discussed for the freeze exception.

Bernhard