Bug#997172: sngrep: FTBFS: curses/ui_manager.c:668:5: error: format not a string literal and no format arguments [-Werror=format-security]

[Lucas Nussbaum]

Source: sngrep
Version: 1.4.9-1
Severity: serious
Justification: FTBFS
Tags: bookworm sid ftbfs

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.


Relevant part (hopefully):
> gcc -DHAVE_CONFIG_H -I.   -Wdate-time -D_FORTIFY_SOURCE=2 -I/usr/include/p11-kit-1   -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -c -o curses/sngrep-ui_call_list.o `test -f 'curses/ui_call_list.c' || echo './'`curses/ui_call_list.c
> curses/ui_manager.c: In function ‘dialog_confirm’:
> curses/ui_manager.c:668:5: error: format not a string literal and no format arguments [-Werror=format-security]
>   668 |     mvwprintw(dialog_win, 1, (width - strlen(title)) / 2, title);
>       |     ^~~~~~~~~
> gcc -DHAVE_CONFIG_H -I.   -Wdate-time -D_FORTIFY_SOURCE=2 -I/usr/include/p11-kit-1   -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -c -o curses/sngrep-ui_call_flow.o `test -f 'curses/ui_call_flow.c' || echo './'`curses/ui_call_flow.c
> gcc -DHAVE_CONFIG_H -I.   -Wdate-time -D_FORTIFY_SOURCE=2 -I/usr/include/p11-kit-1   -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -c -o curses/sngrep-ui_call_raw.o `test -f 'curses/ui_call_raw.c' || echo './'`curses/ui_call_raw.c
> curses/ui_call_flow.c: In function ‘call_flow_draw_message’:
> curses/ui_call_flow.c:574:62: error: format not a string literal and no format arguments [-Werror=format-security]
>   574 |                 mvwprintw(flow_win, cline + 1, startpos + 5, mediastr);
>       |                                                              ^~~~~~~~
> curses/ui_call_flow.c:576:100: error: format not a string literal and no format arguments [-Werror=format-security]
>   576 |                 mvwprintw(flow_win, cline + 1, startpos + distance / 2 - strlen(mediastr) / 2 + 2, mediastr);
>       |                                                                                                    ^~~~~~~~
> gcc -DHAVE_CONFIG_H -I.   -Wdate-time -D_FORTIFY_SOURCE=2 -I/usr/include/p11-kit-1   -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -c -o curses/sngrep-ui_stats.o `test -f 'curses/ui_stats.c' || echo './'`curses/ui_stats.c
> cc1: some warnings being treated as errors
> make[3]: *** [Makefile:877: curses/sngrep-ui_manager.o] Error 1


The full build log is available from:
http://qa-logs.debian.net/2021/10/23/sngrep_1.4.9-1_unstable.log

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please marking it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.