Bug#1026122: linphone-desktop FTCBFS: libapp-plugin.so install location has multiarch tuple twice

[Helmut Grohne]

Source: linphone-desktop
Version: 4.4.10-2
Tags: patch
User: debian-cross at lists.debian.org
Usertags: ftcbfs

linphone-desktop fails to cross build from source. It installs the
libapp-plugin.so to a path that contains the multiarch tuple twice:

| -- Installing: /<<PKGBUILDDIR>>/debian/tmp/<<PKGBUILDDIR>>/build/../../../../usr/lib/arm-linux-gnueabihf/arm-linux-gnueabihf/linphone-desktop/libapp-plugin.so

Later dh_install fails finding it in the expected location. Ultimately,
the cause is a difference in CMAKE_INSTALL_LIBDIR. Usually, this
evaluates to lib/<multiarch> automatically. During cross builds it does
not do this reliably, which is why debhelper passes it explicitly. In
the case of linphone-desktop, this is reversed. It actually becomes
plain lib during native builds and the CMakeLists.txt explicitly append
the tuple. When the cross build passes the one with multiarch, the tuple
ends up twice. My proposed solution is explicitly passing the lib value.
I'm attaching a patch for your convenience.

Beyond this, it fails running patchelf. This is a separate issue that
needs to be fixed in patchelf. I'm filing a separate bug about that.

Helmut
-------------- next part --------------
diff --minimal -Nru linphone-desktop-4.4.10/debian/changelog linphone-desktop-4.4.10/debian/changelog
--- linphone-desktop-4.4.10/debian/changelog	2022-11-27 18:02:24.000000000 +0100
+++ linphone-desktop-4.4.10/debian/changelog	2022-12-14 07:12:58.000000000 +0100
@@ -1,3 +1,10 @@
+linphone-desktop (4.4.10-2.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix FTCBFS: Force a non-multiarch CMAKE_INSTALL_LIBDIR. (Closes: #-1)
+
+ -- Helmut Grohne <helmut at subdivi.de>  Wed, 14 Dec 2022 07:12:58 +0100
+
 linphone-desktop (4.4.10-2) unstable; urgency=medium
 
   * Release to unstable.
diff --minimal -Nru linphone-desktop-4.4.10/debian/rules linphone-desktop-4.4.10/debian/rules
--- linphone-desktop-4.4.10/debian/rules	2022-11-27 18:02:24.000000000 +0100
+++ linphone-desktop-4.4.10/debian/rules	2022-12-14 07:12:58.000000000 +0100
@@ -17,7 +17,8 @@
 		-DGIT_EXECUTABLE=/usr/share/bctoolbox/upstream-version-from-changelog \
 		-DLINPHONE_QT_ONLY=ON \
 		-DENABLE_BUILD_VERBOSE=ON \
-		-DENABLE_UPDATE_CHECK=NO
+		-DENABLE_UPDATE_CHECK=NO \
+		-DCMAKE_INSTALL_LIBDIR=lib
 
 execute_after_dh_auto_build-arch:
 #	patchelf --set-rpath '$$ORIGIN' build/linphone-app/linphone              # breaks dh_dwz