Bug#985314: Fwd: Re: Bug#985314: asterisk spams console output to syslog due to systemd misconfiguration

[Sergio Durigan Junior]

The bug was archived, so the message I sent (below) bounced.  Forwarding
it.

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
https://sergiodj.net/

-------------------- Start of forwarded message --------------------
From: Sergio Durigan Junior <sergiodj at debian.org>
To: Utkarsh Gupta <utkarsh at debian.org>
Cc: berni at debian.org,  985314 at bugs.debian.org
Subject: Re: Bug#985314: asterisk spams console output to syslog due to
 systemd misconfiguration
Date: Wed, 19 Jan 2022 11:49:02 -0500

-------------- next part --------------
On Monday, March 15 2021, Utkarsh Gupta wrote:

> Hi Bernhard,
>
> Thanks for taking care of asterisk. This bug report is just a mere
> forward of what was originally reported in Ubuntu; cf:
> https://bugs.launchpad.net/ubuntu/+source/asterisk/+bug/1909816.
[...]

"Editing patches by hand considered evil" :-).

This upload introduced a problem: the asterisk.service file doesn't
contain the [Install] section anymore, which makes it be treated as a
static unit by systemd.  This means that the service cannot be
enabled/disabled, so when a reboot happens the service doesn't
automatically start.

This has been reported in
https://bugs.launchpad.net/ubuntu/+source/asterisk/+bug/1958259, btw.

The problem happened because the file d/p/systemd.patch was likely
edited by hand, but the diff header was not updated to reflect the new
lines that have been added.  Because of this, 'patch' silently drops the
last 6 lines of the diff when applying it.

The following patch should fix the problem.

Thanks,

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
https://sergiodj.net/

diff --git a/debian/patches/systemd.patch b/debian/patches/systemd.patch
index de803e43..34da8fed 100644
--- a/debian/patches/systemd.patch
+++ b/debian/patches/systemd.patch
@@ -81,7 +81,7 @@ Last-Update: 2016-04-02
 +fi
 --- /dev/null
 +++ b/contrib/asterisk.service
-@@ -0,0 +1,49 @@
+@@ -0,0 +1,55 @@
 +[Unit]
 +Description=Asterisk PBX
 +Documentation=man:asterisk(8)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-voip-maintainers/attachments/20220119/66274742/attachment.sig>
-------------- next part --------------
-------------------- End of forwarded message --------------------