Bug#1049082: libsrtp2: Fails to build source after successful build

[Lucas Nussbaum]

Source: libsrtp2
Version: 2.5.0-3
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> -----------------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package libsrtp2
> dpkg-buildpackage: info: source version 2.5.0-3
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Jonas Smedegaard <dr at jones.dk>
>  dpkg-source --before-build .
>  debian/rules clean
> dh clean
>    debian/rules override_dh_auto_clean
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> dh_auto_clean -- superclean
> 	make -j8 distclean superclean
> make[2]: Entering directory '/<<PKGBUILDDIR>>'
> rm -rf crypto/cipher/cipher.o crypto/cipher/null_cipher.o crypto/cipher/cipher_test_cases.o crypto/cipher/aes_icm_nss.o crypto/cipher/aes_gcm_nss.o crypto/hash/null_auth.o  crypto/hash/auth.o crypto/hash/auth_test_cases.o crypto/hash/hmac_nss.o crypto/math/datatypes.o crypto/kernel/crypto_kernel.o  crypto/kernel/alloc.o crypto/kernel/key.o crypto/kernel/err.o  crypto/replay/rdb.o crypto/replay/rdbx.o srtp/srtp.o TAGS \
> 	libsrtp2.a libsrtp2.so libsrtp2.dll.a core *.core test/core
> for a in * */* */*/*; do			\
> 		  if [ -f "$a~" ] ; then rm -f $a~; fi;	\
> 	done;
> for a in  crypto/test/cipher_driver crypto/test/datatypes_driver crypto/test/kernel_driver  crypto/test/env test/srtp_driver test/replay_driver test/roc_driver test/rdbx_driver test/rtpw test/test_srtp test/rtp_decoder; do rm -rf $a; done
> rm -rf *.pict *.jpg *.dat
> rm -rf freed allocated tmp
> make -C doc clean
> make[3]: Entering directory '/<<PKGBUILDDIR>>/doc'
> rm -rf html/ Doxyfile
> for a in * ; do							\
> 		  if [ -f "$a~" ] ; then rm -f $a~; fi;	\
> 	done;
> make[3]: Leaving directory '/<<PKGBUILDDIR>>/doc'
> make -C fuzzer clean
> make[3]: Entering directory '/<<PKGBUILDDIR>>/fuzzer'
> rm -rf srtp-fuzzer *.o
> make[3]: Leaving directory '/<<PKGBUILDDIR>>/fuzzer'
> rm -rf crypto/include/config.h config.log config.cache config.status \
> 		   Makefile crypto/Makefile doc/Makefile \
> 		   .gdb_history test/.gdb_history .DS_Store
> rm -rf autom4te.cache
> make[2]: Nothing to be done for 'superclean'.
> make[2]: Leaving directory '/<<PKGBUILDDIR>>'
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
>    dh_clean
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building libsrtp2 using existing ./libsrtp2_2.5.0.orig.tar.gz
> dpkg-source: info: using patch list from debian/patches/series
> dpkg-source: info: local changes detected, the modified files are:
>  libsrtp2-2.5.0/fuzzer/Makefile
> dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/libsrtp2_2.5.0-3.diff.yIbbfs
> dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/libsrtp2_2.5.0-3_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.