Bug#1058941: sipxtapi: FTBFS: PlgSpeex.c:21:10: fatal error: speex/speex.h: No such file or directory

[Yavor Doganov]

Source: sipxtapi
Version:  3.3.0~test18+dfsg.1-0.1
Severity: serious
Tags: sid ftbfs patch

This package fails to build from source because it has to build-depend
on libspeex-dev (libspeexdsp-dev only suggests it).  The exact error is:

libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../../../../.. -I../../../../../sipXmediaLib/include -I../../../../../sipXportLib/include -I../../../../../../sipXmediaLib/contrib/libspeex/include -I../../../../../sipXmediaLib/contrib/libspeex/include -Wdate-time -D_FORTIFY_SOURCE=2 -DHAVE_SSL -DDEFAULT_CODECS_PATH=\"/usr/lib/x86_64-linux-gnu/sipxtapi/codecs\" -g -O2 "-ffile-prefix-map=/<<PKGBUILDDIR>>=." -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -DHAVE_SPEEX -D__pingtel_on_posix__ -D_linux_ -D_REENTRANT -D_FILE_OFFSET_BITS=64 -fmessage-length=0 -Wall -Wformat -Wwrite-strings -Wpointer-arith -Wnested-externs -Wmissing-declarations -Wmissing-prototypes -c speex_nb.c  -fPIC -DPIC -o .libs/codec_speex_la-speex_nb.o
In file included from plgspeex.h:16,
                 from speex_nb.c:16:
speex_nb.c:57:33: warning: no previous prototype for ‘speex_get_info_v1_1’ [-Wmissing-prototypes]
   57 | CODEC_API int PLG_GET_INFO_V1_1(speex)(const struct MppCodecInfoV1_1 **codecInfo)
      |                                 ^~~~~
../../../../../sipXmediaLib/include/mp/codecs/PlgDefsV1.h:183:40: note: in definition of macro ‘PLG_GET_INFO_V1_1’
  183 | #define PLG_GET_INFO_V1_1(x)           x##_get_info_v1_1
      |                                        ^
speex_nb.c:66:31: warning: no previous prototype for ‘speex_init_v1_2’ [-Wmissing-prototypes]
   66 | CODEC_API void *PLG_INIT_V1_2(speex)(const char* fmtp, int isDecoder,
      |                               ^~~~~
../../../../../sipXmediaLib/include/mp/codecs/PlgDefsV1.h:184:40: note: in definition of macro ‘PLG_INIT_V1_2’
  184 | #define PLG_INIT_V1_2(x)               x##_init_v1_2
      |                                        ^
speex_nb.c:73:27: warning: no previous prototype for ‘speex_free_v1’ [-Wmissing-prototypes]
   73 | CODEC_API int PLG_FREE_V1(speex)(void* handle, int isDecoder)
      |                           ^~~~~
../../../../../sipXmediaLib/include/mp/codecs/PlgDefsV1.h:188:40: note: in definition of macro ‘PLG_FREE_V1’
  188 | #define PLG_FREE_V1(x)                 x##_free_v1
      |                                        ^
speex_nb.c:78:43: warning: no previous prototype for ‘speex_get_packet_samples_v1_2’ [-Wmissing-prototypes]
   78 | CODEC_API int PLG_GET_PACKET_SAMPLES_V1_2(speex)(void          *handle,
      |                                           ^~~~~
../../../../../sipXmediaLib/include/mp/codecs/PlgDefsV1.h:185:40: note: in definition of macro ‘PLG_GET_PACKET_SAMPLES_V1_2’
  185 | #define PLG_GET_PACKET_SAMPLES_V1_2(x) x##_get_packet_samples_v1_2
      |                                        ^
speex_nb.c:88:30: warning: no previous prototype for ‘speex_decode_v1’ [-Wmissing-prototypes]
   88 | CODEC_API  int PLG_DECODE_V1(speex)(void* handle, const void* pCodedData,
      |                              ^~~~~
../../../../../sipXmediaLib/include/mp/codecs/PlgDefsV1.h:186:40: note: in definition of macro ‘PLG_DECODE_V1’
  186 | #define PLG_DECODE_V1(x)               x##_decode_v1
      |                                        ^
speex_nb.c:97:29: warning: no previous prototype for ‘speex_encode_v1’ [-Wmissing-prototypes]
   97 | CODEC_API int PLG_ENCODE_V1(speex)(void* handle, const void* pAudioBuffer,
      |                             ^~~~~
../../../../../sipXmediaLib/include/mp/codecs/PlgDefsV1.h:187:40: note: in definition of macro ‘PLG_ENCODE_V1’
  187 | #define PLG_ENCODE_V1(x)               x##_encode_v1
      |                                        ^
PlgSpeex.c:21:10: fatal error: speex/speex.h: No such file or directory
   21 | #include <speex/speex.h>
      |          ^~~~~~~~~~~~~~~
compilation terminated.
make[7]: *** [Makefile:576: codec_speex_la-PlgSpeex.lo] Error 1

Trivial patch attached.
-------------- next part --------------
--- debian/control.orig
+++ debian/control
@@ -2,7 +2,7 @@
 Section: libs
 Priority: optional
 Maintainer: Debian VoIP Team <pkg-voip-maintainers at lists.alioth.debian.org>
-Build-Depends: debhelper-compat (= 12), libssl-dev, libcppunit-dev, automake, libpcre3-dev, dpkg-dev (>= 1.16.1~), libxerces-c-dev, pkg-config, libgsm1-dev, libspandsp-dev, libspeexdsp-dev, doxygen, libopus-dev
+Build-Depends: debhelper-compat (= 12), libssl-dev, libcppunit-dev, automake, libpcre3-dev, dpkg-dev (>= 1.16.1~), libxerces-c-dev, pkg-config, libgsm1-dev, libspandsp-dev, libspeexdsp-dev, libspeex-dev, doxygen, libopus-dev
 Homepage: http://www.sipxtapi.org
 Standards-Version: 4.5.0
 Vcs-Git: https://salsa.debian.org/pkg-voip-team/sipxtapi.git