Bug#1031771: linphone-desktop: Update check recommends AppImage

[Daniel Kahn Gillmor]

Hi Dennis--

On Wed 2023-02-22 21:44:20 +0100, Dennis Filder wrote:
> Control: reassign -1 linphone 5.1.65-3
> X-Debbugs-CC: Bastian Germann <bage at debian.org>
>
> On Wed, Feb 22, 2023 at 02:15:09PM +0100, Bastian Germann wrote:
>> The update check in the "burger menu" should be disabled because it
>> downloads the AppImage version of linphone-desktop.
>
> Patching an envvar-overridable early return and warning message into
> linphone/coreapi/update_check.c:linphone_core_check_for_update() seems
> to me like the easiest way to address this.  It would also function as
> a stop-gap for any new mechanisms that try to trigger an update check.

Thanks for this fix!  I notice that the text says:

>>> To enable it restart the program with the variable
>>> LINPHONE_DO_APPIMAGE_DOWNLOAD set to "y" in the environment.

but the actual check is just whether the variable is set, not whether it
is set to "y".

This means that:

    LINPHONE_DO_APPIMAGE_DOWNLOAD=n linphone

will actually enable the check.  Maybe make sure it checks for "y" as
well?

I've offered
https://salsa.debian.org/pkg-voip-team/linphone-stack/linphone/-/merge_requests/3
that tries to do that (but haven't really tested it, sorry!)

        --dkg