Bug#1034661: twinkle: Please update twinkle to latest release

[Frédéric Brière]

On Fri, Apr 21, 2023 at 04:46:20PM +1000, Jason Lewis wrote:
> Please can you update twinkle to the latest release version 1.10.3
> 
> this will at least solve https://github.com/LubosD/twinkle/issues/222

(Upstream co-maintainer speaking.)

To provide some context: the domain name once used by the original
author to host the user manual has now been acquired by scammers
peddling "male enhancement devices" and such.  As you can imagine, this
is not quite what users expect to see when they click on the "Manual"
entry in the Help menu.

This has already been fixed upstream a few years ago, but since we're
unlikely to see a full Twinkle release in the near future, we also put
out a single-fix 1.10.3 release for the sake of distributions, with this
URL change being the only difference between 1.10.2 and 1.10.3.

I'm not sure of the appropriate severity of this bug; there have been
instances of "offensive" material resulting in `important` bugs in the
past, so I'll nudge it in that direction, but this is obviously highly
subjective.

Still, if this is deemed worthy of an unblock request (assuming it's not
too late already), instead of submitting a new version, you may find it
easier to apply the patch[1] yourself, which will achieve the exact same
result.  (In the end, only the one-liner in `mphoneform.cpp` is really
important, if you want to simplify further.)

 [1] https://github.com/LubosD/twinkle/commit/da274607aa835a2735dcf9b9a7ba550910f9d03e