Bug#961434: baresip-core: stack smashing detected with evdev module

[Bastian Germann]

I am uploading a NMU to experimental in order to fix this.
Please consider confirming the transition #1055755 so that it can move to unstable.
-------------- next part --------------
diff -Nru baresip-1.1.0/debian/changelog baresip-1.1.0/debian/changelog
--- baresip-1.1.0/debian/changelog	2023-10-14 16:59:36.000000000 +0000
+++ baresip-1.1.0/debian/changelog	2024-04-10 20:52:08.000000000 +0000
@@ -1,3 +1,11 @@
+baresip (1.1.0-0.2) experimental; urgency=medium
+
+  * Non-maintainer upload
+  * Remove OMX support (see #1065623)
+  * Fix stack smashing (Closes: #961434)
+
+ -- Bastian Germann <bage at debian.org>  Wed, 10 Apr 2024 20:52:08 +0000
+
 baresip (1.1.0-0.1) experimental; urgency=medium
 
   * Non-maintainer upload
diff -Nru baresip-1.1.0/debian/control baresip-1.1.0/debian/control
--- baresip-1.1.0/debian/control	2023-10-14 16:59:36.000000000 +0000
+++ baresip-1.1.0/debian/control	2024-04-10 20:52:03.000000000 +0000
@@ -22,7 +22,6 @@
  libmosquitto-dev,
  libmp3lame-dev,
  libmpg123-dev,
- libomxil-bellagio-dev,
  libopenaptx-dev,
  libopencore-amrnb-dev,
  libopencore-amrwb-dev,
diff -Nru baresip-1.1.0/debian/patches/0002_70a7f45.patch baresip-1.1.0/debian/patches/0002_70a7f45.patch
--- baresip-1.1.0/debian/patches/0002_70a7f45.patch	1970-01-01 00:00:00.000000000 +0000
+++ baresip-1.1.0/debian/patches/0002_70a7f45.patch	2024-04-10 20:52:08.000000000 +0000
@@ -0,0 +1,39 @@
+Origin: upstream, 70a7f456668426a2b59911a04bf42f93a3b2bec6
+From: Sebastian Reimers <hallo at studio-link.de>
+Date: Mon, 16 May 2022 08:19:14 +0200
+Subject: evdev: fix wrong ioctl size (#1843)
+
+found and fixed by debian:
+https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=961434
+---
+ modules/evdev/print.c | 8 ++++----
+ 1 file changed, 4 insertions(+), 4 deletions(-)
+
+diff --git a/modules/evdev/print.c b/modules/evdev/print.c
+index f04f4af4e..6571c1f8f 100644
+--- a/modules/evdev/print.c
++++ b/modules/evdev/print.c
+@@ -42,11 +42,11 @@ void print_name(int fd)
+  */
+ void print_events(int fd)
+ {
+-	uint8_t evtype_bitmask[EV_MAX/8 + 1];
++	uint8_t evbitmask[EV_MAX/8 + 1];
+ 	int i;
+ 
+-	memset(evtype_bitmask, 0, sizeof(evtype_bitmask));
+-	if (ioctl(fd, EVIOCGBIT(0, EV_MAX), evtype_bitmask) < 0) {
++	memset(evbitmask, 0, sizeof(evbitmask));
++	if (ioctl(fd, EVIOCGBIT(0, sizeof(evbitmask)), evbitmask) < 0) {
+ 		warning("evdev: ioctl EVIOCGBIT (%m)\n", errno);
+ 		return;
+ 	}
+@@ -54,7 +54,7 @@ void print_events(int fd)
+ 	printf("Supported event types:\n");
+ 
+ 	for (i = 0; i < EV_MAX; i++) {
+-		if (!test_bit(i, evtype_bitmask))
++		if (!test_bit(i, evbitmask))
+ 			continue;
+ 
+ 		printf("  Event type 0x%02x ", i);
diff -Nru baresip-1.1.0/debian/patches/series baresip-1.1.0/debian/patches/series
--- baresip-1.1.0/debian/patches/series	2023-10-14 16:59:36.000000000 +0000
+++ baresip-1.1.0/debian/patches/series	2024-04-10 20:52:08.000000000 +0000
@@ -1,3 +1,4 @@
+0002_70a7f45.patch
 1002_system_header_locations.patch
 2001_drop_libre_so_check.patch
 2002_test_verbose.patch
diff -Nru baresip-1.1.0/debian/rules baresip-1.1.0/debian/rules
--- baresip-1.1.0/debian/rules	2023-10-14 16:59:36.000000000 +0000
+++ baresip-1.1.0/debian/rules	2024-04-10 20:52:08.000000000 +0000
@@ -26,7 +26,7 @@
 ffmpeg-mods = avcodec avfilter avformat swscale
 gstreamer-mods = gst gst_video
 gtk-mods = gtk
-x11-mods = cairo omx pulse rst sdl vidinfo x11 x11grab
+x11-mods = cairo pulse rst sdl vidinfo x11 x11grab
 
 DEB_MAKE_EXTRA_ARGS = V=1 PREFIX=/usr RELEASE=1 \
 	EXTRA_MODULES="$(core-mods-extra) avfilter swscale" \