Bug#1060275: asterisk: Codec translation notice

[Jonas Smedegaard]

Quoting List Support via Pkg-voip-maintainers (2024-01-30 09:53:05)
> 
> Le 29/01/2024 à 19:34, Jonas Smedegaard a écrit :
> > [...]
> >>> That phrase exists in debian/patches/2016_opus_plc.patch which is
> >>> derived from Xopus/enable_native_plc.patch which (thanks to
> >>> debian/watch) is fetched from original at
> >>> https://github.com/traud/asterisk-opus/blob/asterisk-13.7/enable_native_plc.patch
> >> OK. Questions:
> >>
> >> . what does mean plc ?
> > The purpose of the patch is described at the top of the patch itself.
> /* Determine the amount of lost packets for PLC */ but still I don´t 
> know what is PLC ;)

Ah, now I understand your question :-)

`git grep PLC` reveals that the term "PLC" is described in
Xopus/README.md, which also points to this upstream bugreport with more
details:

https://issues-archive.asterisk.org/ASTERISK-25629


> >> . opus is not used in my case so why I receive those notice ? (Reminder:
> >> allow=!all,g722,alaw,ulaw)
> > If you do not use opus, then configure your Asterisk instance to not
> > *load* the module which you don't want.
> 
> This still doesn't explain why without opus activated (even if loaded) 
> it is involved
> 
> I remove it from modules.conf
> 
> noload => codec_opus_open_source.so
> noload => format_ogg_opus_open_source.so
> noload => res_format_attr_opus.so
> 
> but still the NOTICE appears
> 
> [2024-01-30 09:39:35] NOTICE[2281972][C-00000001]: translate.c:603 
> ast_translate: 244 lost frame(s) 245/0 (gsm at 8000)->(slin at 8000)->(g722 at 16000)
> [2024-01-30 09:39:40] NOTICE[2281972][C-00000001]: translate.c:603 
> ast_translate: 494 lost frame(s) 495/0 (gsm at 8000)->(slin at 8000)->(g722 at 16000)
> [2024-01-30 09:39:45] NOTICE[2281972][C-00000001]: translate.c:603 
> ast_translate: 744 lost frame(s) 745/0 (gsm at 8000)->(slin at 8000)->(g722 at 16000)
> 
> Please notice (:D) that the message appears each 250 frame

Arrgh - I understand now. I have (in a separate email) clarified
subject and severity of this bugreport.


> >> . in src I see /* not DEBUG but NOTICE because of WARNING in
> >> main/cannel.c:__ast_queue_frame */
> >>
> >> DEBUG should be more suitable but as I don´t understant above sentance ...
> > I don't know which severity is more suitable for that code.
> In CLI we always have NOTICE,WARNING and ERROR logs, DEBUG not needed. 
> The above part of our today capture shows that CLI is not really usable 
> with all those messages appart of removing logging NOTICE from CLI

The patch explicitly mentions this in relation to the NOTICE:

> not DEBUG but NOTICE because of WARNING in main/cannel.c:__ast_queue_frame

The function __ast_queue_frame() in main/channel.c contains two
WARNINGs, where the second seems to be the relevant on.  If I
understand the code correctly, when logging af severity WARNING is
enabled and any log messages exist at that point in the code, then the
function breaks after emitting another WARNING.

My guess is that the developers of the Opus patch only really wanted to
emit log messages at DEBUG level, but that it was not possible to do
that because even at WARNING level the function would behave
differently.

Since it seems to only be relevant for debugging purposes, and it causes
pain for non-Opus use in production, I will simply comment out that log
message.

If you want, then it would be helpful if you would followup at either
https://issues-archive.asterisk.org/ASTERISK-25629 or
https://github.com/traud/asterisk-opus/issues sharing your experience
with the Opus patch causing excessive messages when *not* using Opus.


Kind regards,

 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/
 * Sponsorship: https://ko-fi.com/drjones

 [x] quote me freely  [ ] ask before reusing  [ ] keep private
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-voip-maintainers/attachments/20240130/58ca3f7f/attachment-0001.sig>