Bug#1074838: bcmatroska2 FTBFS mostly fixed upstream

[John Scott]

Control: forwarded -1 https://gitlab.linphone.org/BC/public/bcmatroska2/-/commit/7e7e7d0d7037f29624b32d814e83aa2ce978c29f
Control: tags -1 upstream fixed-upstream

GCC 14 is right to treat the issue as an error: calling a function via a function pointer of incompatible type is undefined behavior (and I am assuming here that the function pointer is actually getting used, or else it could be replaced with NULL), and in particular the prototypes switch between passing pointers versus double pointers to different types as arguments. In theory this could cause all sorts of trouble particularly for the less common architectures or when new optimization features are added. For now, upstream has decided to simply add a cast to suppress the error.

This isn't really any worse than the status quo since GCC versions before GCC 13 were happy to do the implicit conversion, but I'd nevertheless like to point out that this doesn't solve the underlying issue that GCC was correct to flag.

-- 
🌐 Homepage https://johnscott.me
🪪 Contact info
	• as a vCard: https://johnscott.me/me/me.vcf
	• as an LDAP directory entry: ldap://johnscott.me/CN=John%20Scott,DC=johnscott,DC=me
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: This is a digitally signed message part
URL: <http://alioth-lists.debian.net/pipermail/pkg-voip-maintainers/attachments/20240725/1acb48e6/attachment-0001.sig>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 6270 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-voip-maintainers/attachments/20240725/1acb48e6/attachment-0001.p7s>