Bug#1071575: dahdi-dkms: module fails to build for Linux 6.8.9: error: implicit declaration of function 'strlcpy'

[Diederik de Haas]

Control: tag -1 upstream fixed-upstream patch

On Tue, 21 May 2024 14:57:47 +0200 Andreas Beckmann <anbe at debian.org> wrote:
> Package: dahdi-dkms
> Version: 1:3.1.0+git20230717~dfsg-5
> Severity: serious
> 
> DKMS make.log for dahdi-3.1.0+git20230717 for kernel 6.8.9-amd64 (x86_64)
> Sun May 19 19:55:53 UTC 2024
> make -C /lib/modules/6.8.9-amd64/build KBUILD_EXTMOD=/var/lib/dkms/dahdi/
> 3.1.0+git20230717/build/drivers/dahdi DAHDI_INCLUDE=/var/lib/dkms/dahdi/
> 3.1.0+git20230717/build/include DAHDI_MODULES_EXTRA="dahdi_dummy.o 
> dahdi_echocan_oslec.o " HOTPLUG_FIRMWARE=yes m
> ...
> /var/lib/dkms/dahdi/3.1.0+git20230717/build/drivers/dahdi/wct4xxp/base.c:
> In function 'free_wc':
> /usr/src/linux-headers-6.8.9-common/include/linux/workqueue.h:625:9: 
> warning: call to '__warn_flushing_systemwide_wq' declared with attribute 
> warning: Please avoid flushing system-wide workqueues. [-Wattribute-warning]
>   625 |         __warn_flushing_systemwide_wq();                                
>   \
>       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This is something upstream should take a look at, but is not the cause of the 
build failure.

>   CC [M]  /var/lib/dkms/dahdi/3.1.0+git20230717/build/drivers/dahdi/xpp/
>   card_global.o 
> /var/lib/dkms/dahdi/3.1.0+git20230717/build/drivers/dahdi/xpp/card_global.c:
> In function 'parse_chip_command':
> /var/lib/dkms/dahdi/3.1.0+git20230717/build/drivers/dahdi/xpp/card_global.c
> :344:9: error: implicit declaration of function 'strlcpy'; did you mean
> 'strscpy'? [-Werror=implicit-function-declaration]> 
>   344 |         strlcpy(buf, cmdline, MAX_PROC_WRITE);  /* Save a copy */
>   
>       |         ^~~~~~~
>       |         strscpy
> 
> cc1: some warnings being treated as errors

But this is.
Attached is the upstream patch for compatibility with 6.8/6.9 kernels added to 
``debian/patches``.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-d-patches-Add-Fix-compilation-issue-for-6.8.y-6.9.y-.patch
Type: text/x-patch
Size: 10655 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-voip-maintainers/attachments/20240527/5404f201/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: This is a digitally signed message part.
URL: <http://alioth-lists.debian.net/pipermail/pkg-voip-maintainers/attachments/20240527/5404f201/attachment-0001.sig>