[PATCH] Funky floats and struct packing are a oldabi arm issue,

Riku Voipio riku.voipio at iki.fi
Sun Aug 26 15:27:13 UTC 2007


so lets not break arm eabi builds (Debian port armel). WTF_PLATFORM_MIDDLE_ENDIAN
is definetly old-abi specific, but the header does not explain where the
struct packing is set. if it's WTF_PLATFORM_ARM, it's wrong. It should
be WTF_PLATFORM_PACK_STRUCTS. Anyway packing already packed stuff is
harmless(?).

---
 JavaScriptCore/wtf/Platform.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/JavaScriptCore/wtf/Platform.h b/JavaScriptCore/wtf/Platform.h
index 533230e..ec685c6 100644
--- a/JavaScriptCore/wtf/Platform.h
+++ b/JavaScriptCore/wtf/Platform.h
@@ -130,8 +130,10 @@
 #if   defined(arm) \
    || defined(__arm__)
 #define WTF_PLATFORM_ARM 1
+#if !defined(__ARM_EABI__)
 #define WTF_PLATFORM_MIDDLE_ENDIAN 1
 #endif
+#endif
 
 /* PLATFORM(X86) */
 #if   defined(__i386__) \
-- 
1.5.2.3


-- 
"rm -rf" only sounds scary if you don't have backups



More information about the Pkg-webkit-maintainers mailing list