1.1.{2,3} release [Was: Re: Bug#519883: please upgrade to allow users to use spacebar]

[Mike Hommey]

On Tue, Mar 17, 2009 at 07:21:49AM +0100, Mike Hommey wrote:
> On Mon, Mar 16, 2009 at 11:30:28PM +0000, Alp Toker wrote:
> > 2009/3/16 Mike Hommey <mh at glandium.org>:
> > > On Mon, Mar 16, 2009 at 09:40:49PM +0100, Mike Hommey wrote:
> > >> > Please also take a look at bug #519924 about missing symbols in the
> > >> > symbols file:
> > >> > - ctiTrampoline at Base 1.1.1
> > >> > - ctiVMThrowTrampoline at Base 1.1.1
> > >> >
> > >> > If these symbols are not in the API it would be safer not to export them,
> > >> > especially considering they are apparently appearing depending on the arch.
> > >> >
> > >> > If you need help with symbols handling, drop me a line ;)
> > >>
> > >> I took a quick look at the issue, and it appears these symbols are
> > >> related to the JIT javascript engine. They shouldn't actually be
> > >> exported, IMHO, as they are implementation detail and not API.
> > >> I think the attached patch may work, though I haven't tested.
> > >
> > > It appears it doesn't work.
> > >
> > 
> > Hi Mike,
> > 
> > Although these symbols aren't used within the statically compiled
> > JavaScriptCore/WebKit, they're invoked by the JIT generated machine
> > code so we do need to export them.
> 
> I'm pretty sure hiding these symbols in some way should work equally
> well.

I verified the attached patch does produce a working webkit (tested on
sunspider)

Mike
-------------- next part --------------
diff --git a/autotools/symbols.filter b/autotools/symbols.filter
index f5af6ba..4964979 100644
--- a/autotools/symbols.filter
+++ b/autotools/symbols.filter
@@ -2,4 +2,5 @@
 local:
 _ZSt*;
 _ZNSt*;
+cti*;
 };
diff --git a/debian/libwebkit-1.0-2.symbols b/debian/libwebkit-1.0-2.symbols
index 11851f1..edddeba 100644
--- a/debian/libwebkit-1.0-2.symbols
+++ b/debian/libwebkit-1.0-2.symbols
@@ -75,8 +75,6 @@ libwebkit-1.0.so.2 libwebkit-1.0-2 #MINVER#
  JSValueToObject at Base 1.1.1
  JSValueToStringCopy at Base 1.1.1
  JSValueUnprotect at Base 1.1.1
- ctiTrampoline at Base 1.1.1
- ctiVMThrowTrampoline at Base 1.1.1
  kJSClassDefinitionEmpty at Base 1.1.1
  webkit_get_default_session at Base 1.1.1
  webkit_major_version at Base 1.1.1