Bug#527096: webkit: FTBFS: Error: suffix or operands invalid for `push'

[Mike Hommey]

On Thu, May 07, 2009 at 11:27:40PM +0200, Sebastian Andrzej Siewior <sebastian at breakpoint.cc> wrote:
> * Mike Hommey | 2009-05-07 22:12:38 [+0200]:
> 
> >On Wed, May 06, 2009 at 11:28:54PM +0200, Sebastian Andrzej Siewior <sebastian at breakpoint.cc> wrote:
> >> -#if PLATFORM(MAC)
> >> +#if PLATFORM(MAC) || defined(__x86_64__)
> >
> >I think this should just all be replaced with
> >#if PLATFORM(X86_64)
> 
> uhm. I've just picked the gcc define. 
> 
> MAC is defined on platform DARWIN which is defined if __APPLE__ is
> present. That is somehow strange since they have powerpc as well don't
> they?
> Anyway X86_64 is defined if either one of __x86_64__, __ia64__, _M_X64
> is found. So your change will also look for SSE2 on ia64 which is wrong
> imho. And we don't look on intel macs anymore (I guess).

IMHO this should be fixed, because ia64 is definitelz not the same
as X86_64. As for PLATFORM(MAC) there seems to be abuse with it,
and it seems to be used in several places where a check for
x86_64 architecture would be the right thing to do.

Mike