Bug#547797: [PATCH] webkit build failure on ia64

Gustavo Noronha Silva kov at debian.org
Tue Sep 22 11:57:19 UTC 2009


On Tue, 2009-09-22 at 11:18 +0200, Mike Hommey wrote:
> > --- webkit-1.1.14/JavaScriptCore/wtf/Platform.h.orig	2009-09-22 08:59:48.000000000 +0000
> > +++ webkit-1.1.14/JavaScriptCore/wtf/Platform.h	2009-09-21 14:55:33.000000000 +0000
> > @@ -294,6 +294,11 @@
> >  #define WTF_PLATFORM_BIG_ENDIAN 1
> >  #endif
> >  
> > +/* PLATFORM(IA64) */
> > +#if defined(__ia64__)
> > +#define WTF_PLATFORM_IA64 1
> > +#endif
> > +
> >  /* PLATFORM(WINCE) && PLATFORM(QT)
> >     We can not determine the endianess at compile time. For
> >     Qt for Windows CE the endianess is specified in the
> > @@ -616,7 +621,7 @@
> >  #endif
> >  
> >  #if !defined(WTF_USE_JSVALUE64) && !defined(WTF_USE_JSVALUE32) && !defined(WTF_USE_JSVALUE32_64)
> > -#if PLATFORM(X86_64) && (PLATFORM(MAC) || PLATFORM(LINUX))
> > +#if (PLATFORM(X86_64) && (PLATFORM(MAC) || PLATFORM(LINUX))) || PLATFORM(IA64)
> >  #define WTF_USE_JSVALUE64 1
> >  #elif PLATFORM(ARM) || PLATFORM(PPC64)
> >  #define WTF_USE_JSVALUE32 1

It looks sane to me. It assumes any ia64 will need it, regardless of the
OS it's running, but I believe that doesn't matter much for ia64 =P

If there's concern you could make it:

#if (PLATFORM(X86_64) && (PLATFORM(MAC) || PLATFORM(LINUX))) || (PLATFORM(LINUX) && PLATFORM(IA64))

Thanks,

-- 
Gustavo Noronha Silva <kov at debian.org>
Debian






More information about the Pkg-webkit-maintainers mailing list