[SCM] WebKit Debian packaging branch, debian/unstable, updated. debian/1.2.1-2-3-g1fe4d84

[Mike Hommey]

On Mon, Jun 28, 2010 at 08:03:35PM -0400, Michael Gilbert wrote:
> On Mon, 28 Jun 2010 19:47:20 -0400 Michael Gilbert wrote:
> 
> > On Mon, 28 Jun 2010 17:48:03 +0200 Mike Hommey wrote:
> > 
> > > On Sun, Jun 27, 2010 at 01:43:30PM +0000, Michael Gilbert wrote:
> > > > The following commit has been merged in the debian/unstable branch:
> > > > commit 1fe4d849b45c080739c685336b18c820cc15c6a8
> > > > Author: Michael Gilbert <michael.s.gilbert at gmail.com>
> > > > Date:   Sun Jun 27 09:44:28 2010 -0400
> > > > 
> > > >     add libtool patch
> > > > 
> > > (snip)
> > > > +   * Use system libtool.
> > > 
> > > Why?
> > 
> > using embedded tools is considered poor practice.  the version included
> > may not be very up to date, and won't be in sync with the version used
> > in the rest of the os.  also security updates won't propagate to the
> > embedded version.  of course, the consequences here are rather small
> > since webkit only uses libtool's build time features, so any window for
> > attack is small.

There is no security benefit using system libtool, but there are
possible drawbacks by the non reproduceability of the build.

> > my basic argument is that its "the right thing to do", but if there is a
> > good argument "why not?", i'll be happy to revert the changes.
> 
> oh, and there were some weird hacks in the rules file to workaround
> an issue in the embedded version.

Do you mean system libtool doesn't reorder arguments? I'd really be
surprised.

Mike