Bug#721206: webkitgtk: FTBFS on hppa: Port to hppa

[John David Anglin]

On 1-Sep-13, at 4:06 PM, Emilio Pozuelo Monfort wrote:

> On 31/08/13 13:15, Emilio Pozuelo Monfort wrote:
>> On 29/08/13 03:49, John David Anglin wrote:
>>> Source: webkitgtk
>>> Version: 2.0.4-2
>>> Severity: normal
>>> Tags: patch
>>>
>>> The webkitgtk package doesn't build on hppa because it hasn't been  
>>> ported.
>>> There is not JIT or assembler support.  For example, the following  
>>> error
>>> occurs:
>>>
>>> g++-4.7 -DHAVE_CONFIG_H -I. -I..  -Wall -W -Wcast-align -Wchar- 
>>> subscripts -Wreturn-type -Wformat -Wformat-security -Wno-format- 
>>> y2k -Wundef -Wmissing-format-attr
>>> ibute -Wpointer-arith -Wwrite-strings -Wno-unused-parameter -Wno- 
>>> parentheses -fn
>>> o-exceptions -DBUILDING_CAIRO__ -DBUILDING_GTK__   -DENABLE_JIT=0 - 
>>> I../Source -I
>>> ../Source/JavaScriptCore -I../Source/JavaScriptCore/API -I../ 
>>> Source/JavaScriptCo
>>> re/assembler -I../Source/JavaScriptCore/bytecode -I../Source/ 
>>> JavaScriptCore/byte
>>> compiler -I../Source/JavaScriptCore/dfg -I../Source/JavaScriptCore/ 
>>> disassembler
>>> -I../Source/JavaScriptCore/heap -I../Source/JavaScriptCore/ 
>>> debugger -I../Source/
>>> JavaScriptCore/ForwardingHeaders -I../Source/JavaScriptCore/ 
>>> interpreter -I../Sou
>>> rce/JavaScriptCore/jit -I../Source/JavaScriptCore/jit -I../Source/ 
>>> JavaScriptCore
>>> /llint -I../Source/JavaScriptCore/parser -I../Source/ 
>>> JavaScriptCore/profiler -I.
>>> ./Source/JavaScriptCore/runtime -I../Source/JavaScriptCore/tools - 
>>> I../Source/Jav
>>> aScriptCore/yarr -I./DerivedSources/JavaScriptCore -I../Source/WTF  
>>> -D_FORTIFY_SOURCE=2  -g -O2 -Wformat -Werror=format-security -Wall  
>>> -Wl,--as-needed -Wno-c++11
>>> -compat -O2 -MT Source/JavaScriptCore/llint/ 
>>> Programs_LLIntOffsetsExtractor-LLIntOffsetsExtractor.o -MD -MP -MF  
>>> Source/JavaScriptCore/llint/.deps/Programs_LLIntO
>>> ffsetsExtractor-LLIntOffsetsExtractor.Tpo -c -o Source/ 
>>> JavaScriptCore/llint/Programs_LLIntOffsetsExtractor- 
>>> LLIntOffsetsExtractor.o `test -f 'Source/JavaScriptCo
>>> re/llint/LLIntOffsetsExtractor.cpp' || echo '../'`Source/ 
>>> JavaScriptCore/llint/LLIntOffsetsExtractor.cpp
>>> In file included from ../Source/JavaScriptCore/bytecode/ 
>>> ValueRecovery.h:31:0,
>>>                 from ../Source/JavaScriptCore/bytecode/ 
>>> CodeOrigin.h:31,
>>>                 from ../Source/JavaScriptCore/bytecode/CodeBlock.h: 
>>> 39,
>>>                 from ../Source/JavaScriptCore/llint/ 
>>> LLIntOffsetsExtractor.cpp:29:
>>> ../Source/JavaScriptCore/assembler/MacroAssembler.h:62:2: error:  
>>> #error "The MacroAssembler is not supported on this platform."
>>> In file included from ../Source/JavaScriptCore/heap/ 
>>> CopiedAllocator.h:29:0,
>>>                 from ../Source/JavaScriptCore/heap/CopiedSpace.h:29,
>>>                 from ../Source/JavaScriptCore/heap/CopyVisitor.h:29,
>>>                 from ../Source/JavaScriptCore/heap/Heap.h:26,
>>>                 from ../Source/JavaScriptCore/runtime/ 
>>> WriteBarrier.h:31,
>>>                 from ../Source/JavaScriptCore/runtime/ 
>>> PropertyStorage.h:29,
>>>                 from ../Source/JavaScriptCore/runtime/ 
>>> IndexingHeader.h:29,
>>>                 from ../Source/JavaScriptCore/runtime/ 
>>> ArrayConventions.h:24,
>>>                 from ../Source/JavaScriptCore/runtime/JSArray.h:24,
>>>                 from ../Source/JavaScriptCore/bytecode/ 
>>> ArrayProfile.h:29,
>>> [...]
>>>
>>> The attached patches provide a minimal port allowing the Debian  
>>> webkitgtk
>>> source package to build.
>>
>> Thanks, I'll apply these for the next upload, but please forward  
>> them to
>> https://bugs.webkit.org/enter_bug.cgi so we don't have to maintain  
>> them.
>>
>>> #define DOUBLE_CONVERSION_CORRECT_DOUBLE_OPERATIONS 1
>>> -#elif CPU(MIPS) || CPU(PPC) || CPU(PPC64) || OS(WINCE) ||  
>>> CPU(SH4) || CPU(S390) || CPU(S390X) || CPU(IA64) || CPU(SPARC) ||  
>>> CPU(ALPHA)
>>> +#elif CPU(MIPS) || CPU(PPC) || CPU(PPC64) || OS(WINCE) ||  
>>> CPU(SH4) || CPU(S390) || CPU(S390X) || CPU(IA64) || CPU(SPARC) ||  
>>> CPU(ALPHA) || defined(__hppa__)
>>
>> You should be able to do CPU(HPPA) there as you have defined  
>> WTF_CPU_HPPA to 1.
>> So do that for consistency.
>
> Added the patches to git, will be part of the next experimental  
> upload (which
> will be uploaded to unstable by the end of September). I have done  
> that change
> to use CPU(HPPA) and have removed the --disable-jit change from  
> debian/rules (as
> we already set -DENABLE_JIT=0 & co which are enough).


Thanks Emilio.  I will forward the source changes after I check that   
CPU(HPPA) works.

Dave
--
John David Anglin	dave.anglin at bell.net