Bug#764341: Re-enable JIT, YARR_JIT and ASSEMBLER on armhf

[Emilio Pozuelo Monfort]

On 07/10/14 17:20, Alberto Garcia wrote:
> On Tue, Oct 07, 2014 at 12:47:04PM +0100, Iain Lane wrote:
>
>> I think that with the change in
>> 9c846a3f60213235e402d1367fea799421e5b82b, armhf was left out of the
>> new list by mistake. We've had it enabled for some time both in
>> Debian and Ubuntu and I'm not aware of any problems.
>
> In the case of armel, there's at least this if we enable JIT:
>
> libtool: compile:  arm-linux-gnueabi-g++ -DHAVE_CONFIG_H -I. -I.. -Wall -W -Wcast-align -Wchar-subscripts -Wreturn-type -Wformat -Wformat-security -Wn
> o-format-y2k -Wundef -Wmissing-format-attribute -Wpointer-arith -Wwrite-strings -Wno-unused-parameter -Wno-parentheses -fno-exceptions -DBUILDING_CAIR
> O__ -DBUILDING_GTK__ -DBUILDING_WEBKIT2__ -I../Source -I../Source/JavaScriptCore -I../Source/JavaScriptCore/API -I../Source/JavaScriptCore/ForwardingH
> eaders -I../Source/JavaScriptCore/assembler -I../Source/JavaScriptCore/bindings -I../Source/JavaScriptCore/bytecode -I../Source/JavaScriptCore/bytecom
> piler -I../Source/JavaScriptCore/debugger -I../Source/JavaScriptCore/dfg -I../Source/JavaScriptCore/disassembler -I../Source/JavaScriptCore/ftl -I../S
> ource/JavaScriptCore/heap -I../Source/JavaScriptCore/inspector -I../Source/JavaScriptCore/inspector/agents -I../Source/JavaScriptCore/interpreter -I..
> /Source/JavaScriptCore/jit -I../Source/JavaScriptCore/llint -I../Source/JavaScriptCore/parser -I../Source/JavaScriptCore/profiler -I../Source/JavaScri
> ptCore/runtime -I../Source/JavaScriptCore/tools -I../Source/JavaScriptCore/yarr -I./DerivedSources/JavaScriptCore -I../Source/WTF -fno-omit-frame-poin
> ter -fno-tree-dce -D_FORTIFY_SOURCE=2 -fno-rtti -pthread -I/usr/include/glib-2.0 -I/usr/lib/arm-linux-gnueabi/glib-2.0/include -I/usr/include -O2 -fst
> ack-protector-strong -Wformat -Werror=format-security -Wall -pthread -std=c++11 -Wno-c++11-compat -O2 -D_FORTIFY_SOURCE=2 -MT Source/JavaScriptCore/ll
> int/libjavascriptcoregtk_3_0_la-LowLevelInterpreter.lo -MD -MP -MF Source/JavaScriptCore/llint/.deps/libjavascriptcoregtk_3_0_la-LowLevelInterpreter.T
> po -c ../Source/JavaScriptCore/llint/LowLevelInterpreter.cpp  -fPIC -DPIC -o Source/JavaScriptCore/llint/.libs/libjavascriptcoregtk_3_0_la-LowLevelInterpreter.o
> /tmp/ccnE2mJd.s: Assembler messages:
> /tmp/ccnE2mJd.s:93: Error: selected processor does not support ARM mode `blx r0'
> /tmp/ccnE2mJd.s:192: Error: selected processor does not support ARM mode `blx r4'
> /tmp/ccnE2mJd.s:213: Error: selected processor does not support ARM mode `blx r0'
> /tmp/ccnE2mJd.s:227: Error: selected processor does not support ARM mode `blx llint_entry_osr'
> /tmp/ccnE2mJd.s:255: Error: selected processor does not support ARM mode `blx llint_entry_osr'
> /tmp/ccnE2mJd.s:285: Error: selected processor does not support ARM mode `blx llint_entry_osr_function_for_call'
> /tmp/ccnE2mJd.s:333: Error: selected processor does not support ARM mode `blx llint_stack_check'
> /tmp/ccnE2mJd.s:355: Error: selected processor does not support ARM mode `blx llint_entry_osr_function_for_construct'
> /tmp/ccnE2mJd.s:404: Error: selected processor does not support ARM mode `blx llint_stack_check'
> /tmp/ccnE2mJd.s:426: Error: selected processor does not support ARM mode `blx llint_entry_osr_function_for_call_arityCheck'
> /tmp/ccnE2mJd.s:447: Error: selected processor does not support ARM mode `blx slow_path_call_arityCheck'
> /tmp/ccnE2mJd.s:501: Error: selected processor does not support ARM mode `blx llint_entry_osr_function_for_construct_arityCheck'
> /tmp/ccnE2mJd.s:522: Error: selected processor does not support ARM mode `blx slow_path_construct_arityCheck'
> [...]
>
> https://wiki.debian.org/ArmEabiPort#Choice_of_minimum_CPU
>
> "So Debian armel runs on a minimum CPU of ARMv4t and by default the
> Debian armel GCC generates code for armv4t (rather than the usual
> default ARM target of armv5t)."
>
> So I guess we either disable JIT or drop support for armv4.

I think we already agreed on the former on IRC.

Emilio