Bug#895969: webkit2gtk: FTBFS on riscv64 due to not linking against libatomic

[Manuel A. Fernandez Montecelo]

Hi,

2018-04-23 10:22 Alberto Garcia:
>On Sun, Apr 22, 2018 at 08:48:19PM +0200, Aurelien Jarno wrote:
>
>> The correct way to link with -pthread instead of -lpthread is to
>> use define THREADS_PREFER_PTHREAD_FLAG before importing the Thread
>> package:
>
>Oh, great, I'll give it a try.
>
>> I haven't tried the patch for webkit2gtk, but it works for
>> qtwebkit. In addition I guess it's necessary to add support for
>> riscv64 in various places of WTF, by defining WTF_CPU_RISCV64. At
>> least it's the case also for qtwebkit.
>
>webkit has now WTF_CPU_UNKNOWN for cases like this so perhaps we don't
>need to do anything else.

I was able to build with the simple patch/debdiff attached (and uploaded
to "unreleased").

I am now sure, though, which knobs need to be modified to make this
happen in the upstream part in the cleanest way.


Cheers.
-- 
Manuel A. Fernandez Montecelo <manuel.montezelo at gmail.com>
-------------- next part --------------
diff -Nru webkit2gtk-2.20.1/debian/changelog webkit2gtk-2.20.1/debian/changelog
--- webkit2gtk-2.20.1/debian/changelog	2018-04-10 20:34:42.000000000 +0200
+++ webkit2gtk-2.20.1/debian/changelog	2018-04-20 15:50:56.000000000 +0200
@@ -1,3 +1,10 @@
+webkit2gtk (2.20.1-1+0.riscv64.1) unreleased; urgency=medium
+
+  * Non-maintainer upload.
+  * riscv64: force build with -pthread
+
+ -- Manuel A. Fernandez Montecelo <mafm at debian.org>  Fri, 20 Apr 2018 13:50:56 +0000
+
 webkit2gtk (2.20.1-1) unstable; urgency=medium
 
   [ Alberto Garcia ]
diff -Nru webkit2gtk-2.20.1/debian/rules webkit2gtk-2.20.1/debian/rules
--- webkit2gtk-2.20.1/debian/rules	2018-04-10 20:34:42.000000000 +0200
+++ webkit2gtk-2.20.1/debian/rules	2018-04-20 15:50:56.000000000 +0200
@@ -7,6 +7,7 @@
 CPPFLAGS = $(shell dpkg-buildflags --get CPPFLAGS) -Wall
 CFLAGS = $(shell dpkg-buildflags --get CFLAGS)
 LDFLAGS = $(shell dpkg-buildflags --get LDFLAGS) -Wl,--as-needed
+LDFLAGS += -pthread
 
 DEBHELPER_VERSION = $(shell dpkg-query -W -f='$${source:Version}' debhelper)