Bug#888543: webkit2gtk: Please reduce optimization level to -O1 on sh3 and sh4

[John Paul Adrian Glaubitz]

Hi!

On 01/27/2018 05:24 PM, Alberto Garcia wrote:
> Is sh3 being built by Debian at all? :-?

No, it is not at the moment. But we are keeping it bootstrappable in
Debian rebootstrap as sh-3 is what will eventually be supported by
the open source J-Core CPU architecture [1].

Adding "sh3" there doesn't hurt but it will make sure we don't run
into this bug again if we decide to bootstrap for sh-3/j-3 in the
future.

> I can apply the patch as-is, but that will affect the whole codebase.
> I wonder if you prefer / have tried to disable -O2 only on the file(s)
> that cause problems? This can be useful:

No, it's fine as is. It's also considered to be a temporary solution
until gcc upstream has been fixed.

> https://gcc.gnu.org/onlinedocs/gcc/Function-Specific-Option-Pragmas.html
> 
> Your patch will go in the next release, so if you change your mind and
> instead of using -O1 globallly you prefer to try with #pragma optimize
> tell me!

This never worked for me. I have tried to use these in the past and I
never managed to apply optimizations for single files. It's also much
easier to modify the debian/rules file than starting to patch the
upstream source.

So, please apply the patch as-is.

Thanks,
Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz at debian.org
`. `'   Freie Universitaet Berlin - glaubitz at physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913