Bug#895969: webkit2gtk: FTBFS on riscv64 due to not linking against libatomic

[Manuel A. Fernandez Montecelo]

2018-04-26 20:04 Alberto Garcia:
>On Wed, Apr 25, 2018 at 11:47:39PM +0200, Manuel A. Fernandez Montecelo wrote:
>> I was able to build with the simple patch/debdiff attached (and uploaded
>> to "unreleased").
>>
>> I am now sure, though, which knobs need to be modified to make this
>> happen in the upstream part in the cleanest way.
>
>I think that the patch proposed by Aurelien is probably the best way:
>
>set(THREADS_PREFER_PTHREAD_FLAG ON)

This was fixed in 2.20.2-1, but it was missing Closes, perhaps
intentionally:

 webkit2gtk (2.20.2-1) unstable; urgency=high
 .
   * New upstream release.
     + This fixes CVE-2018-4200.
   * debian/patches/fix-atomics-build.patch:
     + Set THREADS_PREFER_PTHREAD_FLAG to ON. This fixes the build in
       riscv64 (thanks, Aurelien Jarno).
   * debian/libwebkit2gtk-4.0-doc.install, debian/rules:
     + Update path of installed documentation (see WebKit #184771).

This version built fine in unstable:

  https://buildd.debian.org/status/logs.php?pkg=webkit2gtk&arch=riscv64

Another version is building at the moment, a binNMU: "Rebuild against
libicu60".


However, the one of experimental seems to have the same problem:

  https://buildd.debian.org/status/fetch.php?pkg=webkit2gtk&arch=riscv64&ver=2.21.1-1&stamp=1524285204&raw=0

  ...
  ./obj-riscv64-linux-gnu/Source/JavaScriptCore/./obj-riscv64-linux-gnu/DerivedSources/ForwardingHeaders/wtf/Atomics.h:86: undefined reference to `__atomic_compare_exchange_1'
  ...
  ./obj-riscv64-linux-gnu/Source/JavaScriptCore/./Source/JavaScriptCore/runtime/JSCellInlines.h:365: undefined reference to `__atomic_fetch_or_1'
  ...
  /usr/include/c++/7/bits/atomic_base.h:413: undefined reference to `__atomic_exchange_1'
  /usr/include/c++/7/bits/atomic_base.h:413: undefined reference to `__atomic_exchange_1'
  ...


Cheers.
-- 
Manuel A. Fernandez Montecelo <manuel.montezelo at gmail.com>