Bug#976437: libwebkit2gtk-4.0-37: Websocket sends appens extra bytes to messages

[Sebastien Bacher]

Hey there,

Could someone point out to the libsoup changes needed exactly? Are we
confident they would apply on the 2.64 serie without issue? (and not
impact applications that would need changes to adapt)

Cheers,
Sebastien Bacher

Le 08/12/2020 à 19:35, Alberto Garcia a écrit :
> On Mon, Dec 07, 2020 at 03:12:57PM +0200, Claudio Saavedra wrote:
>> On Mon, 2020-12-07 at 12:46 +0100, Alberto Garcia wrote:
>>
>>> Do I understand correctly that this is due to bugs in libsoup then?
>> Yes. libsoup versions previous to 2.68 don't have a WebSocket
>> implementation that had been thoroughly tested (or tested at all) with
>> WebKit. If you have a WebKit version that uses libsoup's websockets,
>> you MUST use 2.68 or newer. 
>>
>>> If this was working in earlier versions of webkit I only see two
>>> options:
>>>
>>> - Reverting the changes in WebKit (probably  
>>> https://trac.webkit.org/changeset/248099/webkit)
>>> - Updating libsoup, or backporting the relevant fixes (if libsoup is
>>>   indeed buggy).
>> I think in this case the easiest is to actually backport the libsoup
>> bug fixes. It's also what makes more sense from a security perspective,
>> as those are fixes to the websocket implementation in libsoup that is
>> probably used by other applications as well. Reverting the WebKit
>> changeset will not fix libsoup's bugs.
> Ok, adding Simon McVittie and Sebastien Bacher to Cc
>
> Berto