Bug#949621: webkit2gtk: Please pass "--reduce-memory-overheads" on non-Gold targets

[John Paul Adrian Glaubitz]

On 1/22/20 11:29 PM, Alberto Garcia wrote:
> On Wed, Jan 22, 2020 at 10:00:07PM +0100, John Paul Adrian Glaubitz wrote:
> 
>> ifneq (,$(filter $(DEB_HOST_ARCH),hppa m68k powerpc sh4))
>>         LDFLAGS += -Wl,--reduce-memory-overheads
>> endif
> 
> Rather than listing the architectures, perhaps it's easier to have
> cmake take care of that automatically (I haven't tried this yet):
> 
> if (NOT USE_LD_GOLD)
>     set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -Wl,--reduce-memory-overheads")
>     set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -Wl,--reduce-memory-overheads")
> endif ()

Good idea, I agree with that variant.

> Do you have an idea of how much slower this is in practice? The manual
> says the algorithm goes from O(n) to O(n^2), which is no joke.

Doesn't seem so impactful:

> https://build.opensuse.org/package/live_build_log/openSUSE:Factory:PowerPC/webkit2gtk3/standard/ppc64le
> https://build.opensuse.org/package/live_build_log/openSUSE:Factory:PowerPC/webkit2gtk3/standard/ppc64
> https://build.opensuse.org/package/live_build_log/openSUSE:Factory:PowerPC/webkit2gtk3/standard/ppc

ppc is the one built with the option above and without Gold.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz at debian.org
`. `'   Freie Universitaet Berlin - glaubitz at physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913