[pkg-wicd-maint] Bug#833929: wicd-daemon: takes time to reconnect / autoconnect after connection loss

[Vincent Lefevre]

Control: tags -1 patch

On 2017-08-10 11:23:58 +0200, Vincent Lefevre wrote:
> This reminds me bug 582567:
> 
>   https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=582567
> 
> where the problem was:
> 
> > Perhaps the following needs to be modified too:
> > 
> >     def ShouldAutoReconnect(self):
> >         """ Returns True if it's the right time to try autoreconnecting. """
> >         if self.GetAutoReconnect() and not self.CheckIfConnecting() and \
> >            not self.GetForcedDisconnect() and not self.auto_connecting and \
> >            not self.gui_open:
> >             return True
> >         else:
> >             return False
> > 
> > i.e. remove "and not self.gui_open".
> 
> and I see that there is still the same code! So, bug 582567 has
> reappered!

and I've attached the patch.

-- 
Vincent Lefèvre <vincent at vinc17.net> - Web: <https://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)
-------------- next part --------------
Index: wicd-1.7.4+tb2/wicd/wicd-daemon.py
===================================================================
--- wicd-1.7.4+tb2.orig/wicd/wicd-daemon.py
+++ wicd-1.7.4+tb2/wicd/wicd-daemon.py
@@ -457,8 +457,7 @@ class WicdDaemon(dbus.service.Object, ob
     def ShouldAutoReconnect(self):
         """ Returns True if it's the right time to try autoreconnecting. """
         if self.GetAutoReconnect() and not self.CheckIfConnecting() and \
-           not self.GetForcedDisconnect() and not self.auto_connecting and \
-           not self.gui_open:
+           not self.GetForcedDisconnect() and not self.auto_connecting:
             return True
         else:
             return False