[pkg-wicd-maint] Bug#916708: python-wicd: misleading error message "Bad password"

[Vincent Lefevre]

Package: python-wicd
Version: 1.7.4+tb2-6
Severity: important
Tags: patch

On some wireless network with authentication, I systematically got an
error "Bad password". Thus I spent hours trying to find the problem
related to my password, with the impossibility to find the cause of
this issue.

With the wpasupplicant upgrade last week-end, it made clear that the
issue (solved with this upgrade) was not the password, but the TLS
version.

This error message should be changed to "Authentication failed" (which
covers more issues than just a bad password), or something similar.

Patch attached. (Since this is a translated messages, the .po files
also need to be rebuilt and updated.)

-- System Information:
Debian Release: buster/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'stable-updates'), (500, 'unstable'), (500, 'testing'), (500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.18.0-3-amd64 (SMP w/8 CPU cores)
Locale: LANG=POSIX, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=POSIX (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages python-wicd depends on:
ii  net-tools  1.60+git20180626.aebd88e-1
ii  python     2.7.15-3

python-wicd recommends no packages.

Versions of packages python-wicd suggests:
ii  ethtool   1:4.19-1
ii  iproute2  4.18.0-2

Versions of packages wicd depends on:
ii  wicd-curses [wicd-client]  1.7.4+tb2-6
ii  wicd-daemon                1.7.4+tb2-6
ii  wicd-gtk [wicd-client]     1.7.4+tb2-6

Versions of packages wicd-gtk depends on:
ii  python         2.7.15-3
ii  python-glade2  2.24.0-5.1+b1
ii  python-gtk2    2.24.0-5.1+b1
ii  wicd-daemon    1.7.4+tb2-6

Versions of packages wicd-gtk recommends:
ii  menu           2.1.47+b1
ii  policykit-1    0.105-23
ii  python-notify  0.1.1-4

Versions of packages wicd-curses depends on:
ii  python        2.7.15-3
ii  python-urwid  2.0.1-2+b1
ii  wicd-daemon   1.7.4+tb2-6

Versions of packages wicd-curses recommends:
ii  sudo  1.8.26-2

Versions of packages wicd-daemon depends on:
ii  adduser           3.118
ii  dbus              1.12.12-1
ii  debconf           1.5.69
ii  iputils-ping      3:20180629-2
ii  isc-dhcp-client   4.4.1-2
ii  lsb-base          10.2018112800
ii  psmisc            23.2-1
ii  python            2.7.15-3
ii  python-dbus       1.2.8-2+b2
ii  python-gobject-2  2.28.6-13+b1
ii  wireless-tools    30~pre9-13
ii  wpasupplicant     2:2.6-21

Versions of packages wicd-daemon recommends:
ii  rfkill                     2.33-0.2
ii  wicd-curses [wicd-client]  1.7.4+tb2-6
ii  wicd-gtk [wicd-client]     1.7.4+tb2-6

Versions of packages wicd-daemon suggests:
pn  pm-utils  <none>

-- debconf information:
* wicd/users:
-------------- next part --------------
Index: wicd-1.7.4+tb2/wicd/misc.py
===================================================================
--- wicd-1.7.4+tb2.orig/wicd/misc.py
+++ wicd-1.7.4+tb2/wicd/misc.py
@@ -86,7 +86,7 @@ _status_dict = {
     'aborted': _('Connection Cancelled'),
     'association_failed': _('Connection failed: Could not contact the ' + \
         'wireless access point.'),
-    'bad_pass': _('Connection Failed: Bad password'),
+    'bad_pass': _('Connection Failed: Authentication failed'),
     'configuring_interface': _('Configuring wireless interface...'),
     'dhcp_failed': _('Connection Failed: Unable to Get IP Address'),
     'done': _('Done connecting...'),