[pkg-wicd-maint] Bug#964011: wicd-daemon: should be ordered After=network-pre.target

[Simon McVittie]

Package: wicd-daemon
Version: 1.7.4+tb2-6
Severity: normal
Tags: upstream

According to systemd.special(7), network management services like wicd
should be ordered After=network-pre.target. This provides a synchronization
point that can be used by components like iptables and firewalld, to make
sure that they have the opportunity to get firewall rules into place
(if installed and configured) before the network comes up. This was
recently discussed on the systemd-devel mailing list:
https://lists.freedesktop.org/archives/systemd-devel/2020-June/044784.html

For example, NetworkManager.service in NetworkManager implements
this, and so do networking.service and ifup at .service in ifupdown, and
systemd-networkd.service in systemd. However, wicd doesn't currently
seem to do so.

An untested pseudo-patch:

--- other/wicd.service
+++ other/wicd.service
 [Unit]
 Description=Wicd a wireless and wired network manager for Linux
 Wants=network.target
 Before=network.target
+After=network-pre.target
 Documentation=man:wicd(8)

(I don't use wicd myself and I haven't tested this; this bug report is
based on source code inspection.)

Regards,
    smcv