Bug#868431: wmaker: uses static upstream menu

[Doug Torrance]

On 07/22/2017 12:05 PM, Michel Casabona wrote:
> It looks like the change is documented in the changelog
> 
>    * debian/patches/50_def_config_paths.diff
>      - Remove unnecessary patch. It added /etc/GNUstep/Defaults to
>        the DEF_CONFIG_PATHS macro, but the files needed in the paths
>        referenced in this macro (in particular, menu, autostart, and
>        exitscript) will not be located there.
> 
> May be the patch is not yet unnecessary?

I checked out the source, and you're exactly right.  DEF_CONFIG_PATHS is 
used for *any* menu file, not just the default root menu, as I assumed 
when I removed the patch.

Note that without the patch, DEF_CONFIG_PATHS is defined in 
src/wconfig.h as "~/GNUstep/Library/WindowMaker:"PKGDATADIR, where 
PKGDATADIR is "/usr/share/WindowMaker".

I think the easier fix would be to install the Debian menu in 
/usr/share/WindowMaker instead, i.e.:

--- a/debian/wmaker.menu-method
+++ b/debian/wmaker.menu-method
@@ -8,7 +8,7 @@ outputencoding="UTF-8"
  outputlanguage="C"

  genmenu="menu.hook"
-rootprefix="/etc/GNUstep/Defaults"
+rootprefix="/usr/share/WindowMaker"
  userprefix=shell("echo -n /${GNUSTEP_USER_ROOT-GNUstep}") 
"/Library/WindowMaker/"
  treewalk="(M)"
  rootsection="/Debian"


Of course, this all assumes we even want to *keep* the Debian menu in 
Window Maker, which is questionable considering that it has been 
deprecated in 3.9.8.

Doug