Bug#957939: wmbubble: ftbfs with GCC-10

[Matthias Klose]

Package: src:wmbubble
Version: 1.53-2
Severity: normal
Tags: sid bullseye
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-10

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-10/g++-10, but succeeds to build with gcc-9/g++-9. The
severity of this report will be raised before the bullseye release,
so nothing has to be done for the buster release.

The full build log can be found at:
http://people.debian.org/~doko/logs/gcc10-20200225/wmbubble_1.53-2_unstable_gcc10.log
The last lines of the build log are at the end of this report.

To build with GCC 10, either set CC=gcc-10 CXX=g++-10 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-10/porting_to.html

[...]
 dpkg-source --before-build .
dpkg-buildpackage: info: host architecture amd64
 fakeroot debian/rules clean
dh clean
   dh_auto_clean
	make -j1 clean
make[1]: Entering directory '/<<PKGBUILDDIR>>'
sh: 1: git: not found
rm -f wmbubble *.o *.bb* *.gcov gmon.* *.da *~
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   dh_clean
 debian/rules build
dh build
   dh_update_autotools_config
   dh_auto_configure
   dh_auto_build
	make -j1
make[1]: Entering directory '/<<PKGBUILDDIR>>'
sh: 1: git: not found
gcc -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -ansi -Wall -O3 -Wdate-time -D_FORTIFY_SOURCE=2  -c -o bubblemon.o bubblemon.c
In file included from /usr/include/string.h:495,
                 from bubblemon.c:56:
In function ‘strncpy’,
    inlined from ‘print_usage’ at bubblemon.c:328:3:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:10: warning: ‘__builtin_strncpy’ specified bound 32 equals destination size [-Wstringop-truncation]
  106 |   return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
bubblemon.c: In function ‘render_secondary’:
bubblemon.c:1031:24: warning: ‘%6lu’ directive output may be truncated writing between 6 and 14 bytes into a region of size 8 [-Wformat-truncation=]
 1031 |    snprintf(number, 8, "%6"PRIu64"M", bm.mem_used >> 20);
      |                        ^~~~
bubblemon.c:1031:25: note: format string is defined here
 1031 |    snprintf(number, 8, "%6"PRIu64"M", bm.mem_used >> 20);
bubblemon.c:1031:24: note: directive argument in the range [0, 17592186044415]
 1031 |    snprintf(number, 8, "%6"PRIu64"M", bm.mem_used >> 20);
      |                        ^~~~
In file included from /usr/include/stdio.h:867,
                 from bubblemon.c:50:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:67:10: note: ‘__builtin___snprintf_chk’ output between 8 and 16 bytes into a destination of size 8
   67 |   return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   68 |        __bos (__s), __fmt, __va_arg_pack ());
      |        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
bubblemon.c:1040:24: warning: ‘%6lu’ directive output may be truncated writing between 6 and 14 bytes into a region of size 8 [-Wformat-truncation=]
 1040 |    snprintf(number, 8, "%6"PRIu64"M", bm.swap_used >> 20);
      |                        ^~~~
bubblemon.c:1040:25: note: format string is defined here
 1040 |    snprintf(number, 8, "%6"PRIu64"M", bm.swap_used >> 20);
bubblemon.c:1040:24: note: directive argument in the range [0, 17592186044415]
 1040 |    snprintf(number, 8, "%6"PRIu64"M", bm.swap_used >> 20);
      |                        ^~~~
In file included from /usr/include/stdio.h:867,
                 from bubblemon.c:50:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:67:10: note: ‘__builtin___snprintf_chk’ output between 8 and 16 bytes into a destination of size 8
   67 |   return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   68 |        __bos (__s), __fmt, __va_arg_pack ());
      |        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
gcc -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -ansi -Wall -O3 -Wdate-time -D_FORTIFY_SOURCE=2  -c -o wmx11pixmap.o wmx11pixmap.c
gcc -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -ansi -Wall -O3 -Wdate-time -D_FORTIFY_SOURCE=2  -c -o sys_linux.o sys_linux.c
gcc -Wl,-z,relro -o wmbubble bubblemon.o wmx11pixmap.o sys_linux.o -lX11 -lm
/usr/bin/ld: wmx11pixmap.o:./wmx11pixmap.h:29: multiple definition of `wmxp_display'; bubblemon.o:./wmx11pixmap.h:29: first defined here
/usr/bin/ld: wmx11pixmap.o:./wmx11pixmap.h:30: multiple definition of `wmxp_iconwin'; bubblemon.o:./wmx11pixmap.h:30: first defined here
/usr/bin/ld: wmx11pixmap.o:./wmx11pixmap.h:30: multiple definition of `wmxp_win'; bubblemon.o:./wmx11pixmap.h:30: first defined here
collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:79: wmbubble] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: error: make -j1 returned exit code 2
make: *** [debian/rules:4: build] Error 25
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2