Bug#957953: wmtv: ftbfs with GCC-10

[Matthias Klose]

Package: src:wmtv
Version: 0.6.6-1
Severity: normal
Tags: sid bullseye
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-10

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-10/g++-10, but succeeds to build with gcc-9/g++-9. The
severity of this report will be raised before the bullseye release,
so nothing has to be done for the buster release.

The full build log can be found at:
http://people.debian.org/~doko/logs/gcc10-20200225/wmtv_0.6.6-1_unstable_gcc10.log
The last lines of the build log are at the end of this report.

To build with GCC 10, either set CC=gcc-10 CXX=g++-10 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-10/porting_to.html

[...]
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking whether gcc understands -c and -o together... yes
checking whether make supports the include directive... yes (GNU style)
checking dependency style of gcc... none
checking for pkg-config... /usr/bin/pkg-config
checking pkg-config is at least version 0.9.0... yes
checking for x11... yes
checking for xext... yes
checking for xpm... yes
checking for xxf86dga... yes
checking for xxf86vm... yes
checking for libv4l1... yes
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: executing depfiles commands
configure: WARNING: unrecognized options: --disable-maintainer-mode
   dh_auto_build
	make -j1
make[1]: Entering directory '/<<PKGBUILDDIR>>'
gcc -DPACKAGE_NAME=\"wmtv\" -DPACKAGE_TARNAME=\"wmtv\" -DPACKAGE_VERSION=\"0.6.6\" -DPACKAGE_STRING=\"wmtv\ 0.6.6\" -DPACKAGE_BUGREPORT=\"wmaker-dev at lists.windowmaker.org\" -DPACKAGE_URL=\"\" -DPACKAGE=\"wmtv\" -DVERSION=\"0.6.6\" -I.   -Wdate-time -D_FORTIFY_SOURCE=2       -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -c -o src/wmtv.o src/wmtv.c
src/wmtv.c: In function ‘main’:
src/wmtv.c:668:8: warning: ‘XKeycodeToKeysym’ is deprecated [-Wdeprecated-declarations]
  668 |        switch(XKeycodeToKeysym(display, Event.xkey.keycode, 0)) {
      |        ^~~~~~
In file included from src/wmtv.c:40:
/usr/include/X11/Xlib.h:1687:15: note: declared here
 1687 | extern KeySym XKeycodeToKeysym(
      |               ^~~~~~~~~~~~~~~~
src/wmtv.c: In function ‘DrawPresetChan’:
src/wmtv.c:1093:18: warning: ‘%02d’ directive writing between 2 and 11 bytes into a region of size 10 [-Wformat-overflow=]
 1093 |   sprintf(temp, "%02d", cchannel+1);
      |                  ^~~~
src/wmtv.c:1093:17: note: directive argument in the range [-2147483647, 2147483647]
 1093 |   sprintf(temp, "%02d", cchannel+1);
      |                 ^~~~~~
In file included from /usr/include/stdio.h:867,
                 from src/wmtv.c:22:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:36:10: note: ‘__builtin___sprintf_chk’ output between 3 and 12 bytes into a destination of size 10
   36 |   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   37 |       __bos (__s), __fmt, __va_arg_pack ());
      |       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/wmtv.c: In function ‘main’:
src/wmtv.c:548:43: warning: ‘%d’ directive output may be truncated writing between 1 and 11 bytes into a region of size 3 [-Wformat-truncation=]
  548 |               snprintf(expansions[0], 3, "%d", cchannel+1);
      |                                           ^~
src/wmtv.c:548:42: note: directive argument in the range [-2147483647, 2147483647]
  548 |               snprintf(expansions[0], 3, "%d", cchannel+1);
      |                                          ^~~~
In file included from /usr/include/stdio.h:867,
                 from src/wmtv.c:22:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:67:10: note: ‘__builtin___snprintf_chk’ output between 2 and 12 bytes into a destination of size 3
   67 |   return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   68 |        __bos (__s), __fmt, __va_arg_pack ());
      |        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
gcc -DPACKAGE_NAME=\"wmtv\" -DPACKAGE_TARNAME=\"wmtv\" -DPACKAGE_VERSION=\"0.6.6\" -DPACKAGE_STRING=\"wmtv\ 0.6.6\" -DPACKAGE_BUGREPORT=\"wmaker-dev at lists.windowmaker.org\" -DPACKAGE_URL=\"\" -DPACKAGE=\"wmtv\" -DVERSION=\"0.6.6\" -I.   -Wdate-time -D_FORTIFY_SOURCE=2       -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -c -o src/wmgeneral/wmgeneral.o src/wmgeneral/wmgeneral.c
gcc       -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security  -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -o wmtv src/wmtv.o src/wmgeneral/wmgeneral.o  -lX11 -lXext -lXpm -lX11 -lXxf86dga -lXxf86vm -lv4l1
/usr/bin/ld: src/wmgeneral/wmgeneral.o:./src/wmgeneral/wmgeneral.h:39: multiple definition of `display'; src/wmtv.o:./src/wmgeneral/wmgeneral.h:39: first defined here
collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:421: wmtv] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: error: make -j1 returned exit code 2
make: *** [debian/rules:7: build] Error 25
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2