[Pkg-wmaker-devel] Bug#792214: Icons and screen border

[Doug Torrance]

Control: forwarded -1 wmaker-dev at lists.windowmaker.org

Hi everyone,

While investigating Debian bug #792214 [1], I noticed some peculiar 
behavior.

Suppose icons are positioned (using "Icon Positioning" in the "Icon 
Preferences" tab of WPrefs) on the same side of the screen as the dock.

Suppose no icons are currently on the screen (aside from the clip/dock). 
  Open an application or minimize an existing application.  The icon 
will appear on the edge of the screen.

However, move to a different workspace, or some other behavior that 
causes Window Maker to rearrange the icons, and the icons will move over 
to accommodate the dock, even if the dock is nowhere nearby.  This is 
due the following code in src/actions.c (in the wArrangeIcons function):

		if (scr->dock) {
			int offset = wPreferences.icon_size + DOCK_EXTRA_SPACE;

			if (scr->dock->on_right_side)
				area.x2 -= offset;
			else
				area.x1 += offset;
		}

It would be preferable, I think, if the behavior was consistent.  I see 
several options:

* Always draw the icons on the edge of the screen (i.e., remove the 
above code).
* Always leave room for the dock (i.e., put similar code in the other 
places where icons are originally placed).
* Detect whether the icons would actually intersect with the dock and 
choose one of the above options accordingly.

Any thoughts?

Doug

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=792214