[Pkg-xen-devel] Some words on my debian files...

[Ralph Passgang]

Am Donnerstag, 16. Februar 2006 17:48 schrieb Ralph Passgang:
> Am Donnerstag, 16. Februar 2006 16:29 schrieb Guido Trotter:
> > On Thu, Feb 16, 2006 at 02:28:36PM +0100, Ralph Passgang wrote:

[...]

> > > - My packages are also building & working on amd64 but I am not sure if
> > > I made it correct. I noticed that xen wants to install libraries in
> > > /lib64, but debian expects them to be in /lib (because /lib64 is just a
> > > symlink to /lib). I managed that by having the libraries moved to the
> > > correct location on amd64 hosts before the files gets packaged (see
> > > debian/rules), but I guess it would be better to tell the correct
> > > library path at configure/compile-time and not using a hook like this..
> >
> > Well, it's just because other distros are mixed 32-64 while debian is
> > pure 64 (and one can build a 32bit chroot, if he wants too...) so lib64
> > isn't needed...
> >
> > I think we can apply this patch with dpatch before starting the
> > compilation, and that should solve most of the issue! I don't have an
> > amd64 handy to try it, though!
> >
> > diff -ru xen-3.0.1.orig/Config.mk xen-3.0.1/Config.mk
> > --- xen-3.0.1.orig/Config.mk    2006-02-16 16:19:44.000000000 +0100
> > +++ xen-3.0.1/Config.mk 2006-02-16 16:20:10.000000000 +0100
> > @@ -27,11 +27,7 @@
> >  INSTALL_DATA = $(INSTALL) -m0644
> >  INSTALL_PROG = $(INSTALL) -m0755
> >
> > -ifeq ($(XEN_TARGET_ARCH),x86_64)
> > -LIBDIR = lib64
> > -else
> >  LIBDIR = lib
> > -endif
> >
> >  ifneq ($(EXTRA_PREFIX),)
> >  EXTRA_INCLUDES += $(EXTRA_PREFIX)/include
> >
> > Ciao,
> >
> > Guido
> >
> > PS there are a couple more files in the source which references lib64, we
> > might have to dpatch those too... Or see if we can make the patch so that
> > it only affects debian, and then can be accepted upstream too...
>
>  I can check your patch on a amd64 box if you would like that, but I am not
> sure what is the better way to solve this, really.
>
> I personally don't like patching upstream if it's not really neccessary. I
> am not sure if my hook is really so bad that patching upstream is the
> better solution. what about the others?
>
> ah, and before everybody has to look it up. my "hook" looks like this:
>
> (if [ "$(DEB_BUILD_ARCH)" == "amd64" ]; then \
>    cp -a $(CURDIR)/debian/install/usr/lib64/*
> $(CURDIR)/debian/install/usr/lib/; \
>    rm -rf $(CURDIR)/debian/install/usr/lib64 ;\
> fi)
>
> --Ralph

I checked your patch and it's working perfectly on my amd64 box... so go on 
with adding this as dpatch and then please also remove my amd64 hook from the 
rules files...

--Ralph