[Pkg-xen-devel] Do we have one make more than necessary?

[Guido Trotter]

On Mon, Feb 20, 2006 at 12:04:33AM +0100, Ralph Passgang wrote:

Hi,

> I am not sure... I haven't changed that from adam's version, but I guess that  
> the "make all" call just builds everything and "make dist" installs it then. 
> (So it matches the build & install target of our rules file).
> 
> In that case we should be able to remove the "make all" call and just use 
> "make dist" because make dist will build and install everything then. But 
> which section of our rules file is the correct place then? "build:" or 
> "install:" ? :)
> 

Actually make all and make dist are exactly the same, as the upstream makefile
has:

# Default target must appear before any include lines
all: dist

So what seems to be happening is that the first make builds and installs
everything, then the directory in which it is installed gets removed in the
install target, and then make dist is called again and installs everything
again!

I was checking again our dear friend the debian policy and it seems we're not
behaving very well, so we need some changes before the usual thing happens! :)

We don't have the binary-arch and binary-indep targets, which are a policy
*must* and we behave strangely various times... So today I'll try to clean up
and straighten the rules file a bit!

> But by doing this, we would have only one make call (+ for i386 the make 
> mrproper and make xen call). If this is all we really need we should do this, 
> because it keeps the rules file simple :)
> 

Yeah, we probably should!

> As said I have to check the pae thing tomorrow. I can build the testing 
> packages with just one "make dist" call (+ of course the pae stuff) and also 
> test that, so we know if we can safely remove the useless "make all" call.
> 

Ok, go ahead and check PAE, I'm working a bit on debian/rules that it seems like
this is a bit problematic! :/

Guido