[Pkg-xen-devel] Bug#408739: xen-utils-common: xendomans script sets WDOG_PID and then references WDOG_PIG

[Mike McCallister]

Package: xen-utils-common
Version: 3.0.3-0-2
Severity: normal


While reviewing the contents of /etc/init.d/xendomains, I noticed that
the script sets a variable named WDOG_PID but later references an
uninitialized variable named WDOG_PIG.  I'm not sure how much this
impairs the behavior of Xen, so I left the severity at "normal".  See
below for a simple patch:

--- xendomains.orig     2007-01-27 18:42:02.000000000 -0600
+++ xendomains  2007-01-27 18:42:22.000000000 -0600
@@ -305,9 +305,9 @@
            if test $? -ne 0; then
                rc_failed $?
                echo -n '!'
-               kill $WDOG_PIG >/dev/null 2>&1
+               kill $WDOG_PID >/dev/null 2>&1
            else
-               kill $WDOG_PIG >/dev/null 2>&1
+               kill $WDOG_PID >/dev/null 2>&1
                continue
            fi
        fi
@@ -321,7 +321,7 @@
                rc_failed $?
                echo -n '!'
            fi
-           kill $WDOG_PIG >/dev/null 2>&1
+           kill $WDOG_PID >/dev/null 2>&1
        fi
     done < <(xm list | grep -v '^Name')



-- System Information:
Debian Release: 4.0
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.16-xen3.0.2-phydomu
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)