[Pkg-xen-devel] Bug#481105: Bug#481105: [PATCH] adjust patch to pygrub and hvmloader

[Ian Campbell]

On Sun, 2008-07-20 at 17:53 +0200, Bastian Blank wrote:
> On Sun, Jul 20, 2008 at 02:32:54PM +0100, Ian Campbell wrote:
> > I just tripped over this issue with pygrub. The code is written such
> > that saying bootloader="pygrub" should cause the correct path to be
> > used, the attached patch simply fixes this path to be correct.
> 
> No, this is not the correct fix. The value should be rewritten in
> tools/python/xen/xm/create.py, but this seems to not work correctly.

You mean to change:
   if vals.bootloader:
        if vals.bootloader == "pygrub":
            vals.bootloader = osdep.pygrub_path
instead of changing the definition of osdep.pygrub_path? Why is that
preferred? It seems like the whole purpose of the osdep module is to
abstract away differences between OSs (and distros...)

Ian
-- 
Ian Campbell

 Alter.net seems to have replaced one of its router with a zucchini.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
Url : http://lists.alioth.debian.org/pipermail/pkg-xen-devel/attachments/20080720/16f2d2e8/attachment.pgp