[Pkg-xen-devel] Bug#677244: xen-utils-common: xen-toolstack fails if either `xm` or `xl` is not found in xen-dir

[Colomban Wendling]

Package: xen-utils-common
Version: 4.1.2-7
Severity: grave
Tags: patch
Justification: renders package unusable

Dear Maintainer,

The script /usr/lib/xen-common/bin/xen-toolstack improperly aborts if *either*
`xm` or `xl` cannot be found in the xen-dir (/usr/lib/xen-4.0/bin).  This means
that a default installation (e.g. following Debian wiki on the subject, namely
installing xen-linux-system and xen-tools without any configuration) will NOT be
usable as-is because it "cannot find an usable toolstack".

This is due to a bug in the error handling of the xen-toolstack script when it
comes to checking the availability of `xm` and `xl`.  Since the script is run
with `sh -e` and the return value of `command -v` isn't used, the script aborts.

Attached is a tiny patch fixing the issue by using the `command -v` return value.


Best regards,
Colomban

-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.utf8, LC_CTYPE=fr_FR.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages xen-utils-common depends on:
ii  gawk            1:4.0.1+dfsg-2
ii  lsb-base        4.1+Debian7
ii  python          2.7.3~rc2-1
ii  ucf             3.0025+nmu3
ii  udev            175-3.1
ii  xenstore-utils  4.1.2-7

xen-utils-common recommends no packages.

xen-utils-common suggests no packages.

-- no debconf information
-------------- next part --------------
A non-text attachment was scrubbed...
Name: xen-toolstack-check-fix.patch
Type: text/x-diff
Size: 338 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-xen-devel/attachments/20120612/b79f3f8b/attachment.patch>