[Pkg-xen-devel] Bug#697409: xen-utils-4.1: pygrub does not correctly distinguish between "disk with partitions" and "partition"

[Marvin Renich]

Package: xen-utils-4.1
Version: 4.1.3-7
Severity: normal

The function is_disk_image in /usr/lib/xen-4.1/bin/pygrub at line 45
distinguishes a partitioned disk from a partition by looking for 0xaa55
at offset 0x1fe in the image, but this is the bootsector signature, not
the partition table signature.  extlinux and other bootloaders put this
signature there on bootable partitions (which don't have partition
tables).

A better heuristic, though still very fallible, would be to check if all
four pairs of [start-sector, sector-count] entries were either [0,0] or
reasonable for the size of the file (if the file size can be
determined), and that at least one pair is not [0,0].

...Marvin


-- System Information:
Debian Release: 7.0
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'stable-updates'), (500, 'unstable'), (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.2.0-4-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages xen-utils-4.1 depends on:
ii  e2fslibs          1.42.5-1
ii  libc6             2.13-37
ii  libgnutls26       2.12.20-2
ii  libncurses5       5.9-10
ii  libpci3           1:3.1.9-6
ii  libtinfo5         5.9-10
ii  libuuid1          2.20.1-5.3
ii  libxen-4.1        4.1.3-7
ii  libxenstore3.0    4.1.3-7
ii  python            2.7.3~rc2-1
ii  python2.7         2.7.3~rc2-2.1
ii  xen-utils-common  4.1.3-7
ii  zlib1g            1:1.2.7.dfsg-13

Versions of packages xen-utils-4.1 recommends:
ii  bridge-utils                                   1.5-6
ii  qemu-keymaps                                   1.1.2+dfsg-3
ii  qemu-utils                                     1.1.2+dfsg-3
ii  xen-hypervisor-4.1-amd64 [xen-hypervisor-4.1]  4.1.3-7

Versions of packages xen-utils-4.1 suggests:
ii  xen-docs-4.1  4.1.3-7

-- no debconf information